Fix handling of data_priority = profileFilter on submission/modificat… #2921
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@adamabeshouse i'm gonna write a test for this later today |
| @@ -2009,7 +2010,7 @@ export class QueryStore { | |||
| : (profileIds.filter(_.identity) as string[]); | |||
| this.zScoreThreshold = params.Z_SCORE_THRESHOLD || '2.0'; | |||
| this.rppaScoreThreshold = params.RPPA_SCORE_THRESHOLD || '2.0'; | |||
| this.dataTypePriorityCode = params.data_priority || '0'; | |||
| this.dataTypePriorityCode = params.data_priority || params.profileFilter || '0'; | |||
There was a problem hiding this comment.
can this parsing be brought into urlwrapper since its handling the aliasing?
There was a problem hiding this comment.
truth be known (is that a phrase? no, but i still like it), we could do away with params.data_priority here because it's an instance of urlWrapper that is being passed. But then we would have to do some refactoring and i want to just get this out. we can follow up with refactoring. won't be too hard
adamabeshouse
approved these changes
Dec 9, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
urlWrapper was not correctly handling the legacy data_priority as an alias for profileFilter. On multi-study queries this broke filtering.