Fix overwriting of empty parameters on modify query (and all other updateURL calls) #2925
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alisman
changed the title
alisman
commented
Dec 11, 2019
| @@ -90,6 +72,13 @@ export default class ExtendedRouterStore extends RouterStore { | |||
| newQuery = newParams; | |||
| } | |||
|
|
|||
| // clear out any undefined props | |||
There was a problem hiding this comment.
newQuery will have ALL params in URL, so here we can just delete entrees that are empty. nothing can survive.
alisman
commented
Dec 11, 2019
| @@ -25,14 +25,6 @@ export function queryParams(nonMolecularProfileParams:NonMolecularProfileQueryPa | |||
| molecularProfileParams:MolecularProfileQueryParams) { | |||
| let params:CancerStudyQueryUrlParams = Object.assign({}, nonMolecularProfileParams, molecularProfileParams); | |||
|
|
|||
| // Remove params with no value, because they may cause problems. | |||
| // For example, the server will always transpose if transpose_matrix is present, no matter the value. | |||
| for (let key in params) { | |||
There was a problem hiding this comment.
doing this here meant that the routing store updateURL call would not get a value for this param, which would then allow any OLD param to be retained
…te undefined params
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to URLWrapper, modify query cleared all existing query params and replaced them with newly submitted. But ULWrapper changed that to allow persisting of existing non-URL sessions. A problem arose when we submit an empty parameter (e.g. mutation profile type). On submit the code was stripping out empty params which had the affect of retaining the old value. THis is fixed by accomplishing the overwrite in the routing store where we ALWAYS overwrite all the URL params.
Fixes: cBioPortal/cbioportal#6894
To reproduce bug, make a single study query and then modify query by updating genomic profile. You can't update it.