oncoprint - open data in oncoprinter #3227
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
adamabeshouse
commented
May 22, 2020
•
adamabeshouse
commented
adamabeshouse
force-pushed
the
download-oncoprinter-data
branch
from
b9b7660
to
bf4cf47
Compare
adamabeshouse
changed the title
adamabeshouse
force-pushed
the
download-oncoprinter-data
branch
from
bf4cf47
to
21a3a4e
Compare
|
Very cool! Would it be hard to support mutational spectrum? Maybe they can be supplied as clinical data in the same format as in download (I couldn't find the issue about it somehow). When heatmap is added, maybe also add a warning that heatmap will not be supported. (or can we support heatmap as well? |
onursumer
approved these changes
May 29, 2020
| @@ -339,7 +329,7 @@ function makeGeneticTrackDatum_Data_Type3(oncoprinterInputLine:OncoprinterInputL | |||
| return ret as OncoprinterGeneticTrackDatum_Data; | |||
| }*/ | |||
|
|
|||
| export function makeGeneticTrackDatum_Data_Type2( | |||
| export function makeGeneticTrackDatum_Data( | |||
There was a problem hiding this comment.
was there a specific reason to have mixed case function names?
There was a problem hiding this comment.
I guess its just supposed to make these huge type names a little easier to comprehend
src/pages/staticPages/tools/oncoprinter/OncoprinterImportUtils.ts
Outdated
Show resolved
Hide resolved
adamabeshouse
force-pushed
the
download-oncoprinter-data
branch
3 times, most recently
from
35a62dd
to
44107b3
Compare
adamabeshouse
force-pushed
the
download-oncoprinter-data
branch
2 times, most recently
from
a3e5e3c
to
bd092d0
Compare
added 7 commits
June 5, 2020 16:39
…um clinical track) in oncoprinter Signed-off-by: Abeshouse, Adam A./Sloan Kettering Institute <abeshoua@mskcc.org>
Signed-off-by: Abeshouse, Adam A./Sloan Kettering Institute <abeshoua@mskcc.org>
… oncoprinter Signed-off-by: Abeshouse, Adam A./Sloan Kettering Institute <abeshoua@mskcc.org>
…coprint coloring for it. Also fix typescript errors Signed-off-by: Abeshouse, Adam A./Sloan Kettering Institute <abeshoua@mskcc.org>
Signed-off-by: Abeshouse, Adam A./Sloan Kettering Institute <abeshoua@mskcc.org>
Signed-off-by: Abeshouse, Adam A./Sloan Kettering Institute <abeshoua@mskcc.org>
Signed-off-by: Abeshouse, Adam A./Sloan Kettering Institute <abeshoua@mskcc.org>
adamabeshouse
force-pushed
the
download-oncoprinter-data
branch
from
84f9daa
to
bfd8d4b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.