Fix the allele frequency issue in multi-sample patient view #3950
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhx828
commented
Aug 26, 2021
adamabeshouse
requested changes
Aug 26, 2021
| @@ -34,4 +35,24 @@ describe('patient page', function() { | |||
| 'show all 4 samples'.toLowerCase() | |||
| ); | |||
| }); | |||
|
|
|||
| it('should show number under allele frequency column for multiple samples patient in one sample view', function() { | |||
There was a problem hiding this comment.
i think it would be better to make these tests not screenshot tests. screenshots can be so annoying to deal with and update, and flakey, and this is a situation that is really suited to just checking whether an element appears and if its value is what we expect it is.
zhx828
force-pushed
the
update-allele-freq
branch
from
b0f57be
to
094e49a
Compare
Signed-off-by: Hongxin <5400599+zhx828@users.noreply.github.com>
zhx828
force-pushed
the
update-allele-freq
branch
from
883c8bd
to
d35cc37
Compare
|
The failing tests are irrelevant. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to fix an issue introduced by #3931
The allele frequency is not shown when the mutation only exists for one sample in the multi-sample patient view.