Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dbSnp* and Oncotator* related fields in frontend and backend #9779

Closed
16 tasks done
jagnathan opened this issue Aug 30, 2022 · 7 comments
Closed
16 tasks done

Remove dbSnp* and Oncotator* related fields in frontend and backend #9779

jagnathan opened this issue Aug 30, 2022 · 7 comments
Assignees
Labels

Comments

@jagnathan
Copy link
Collaborator

jagnathan commented Aug 30, 2022

Remove OncotatorProteinPosStar, OncotatorProteinPosEnd, getOncotatorRefseqMrnaId fields in frontend and backend

The changes require both frontend and backend changes. Frontend can be release ahead of backend or both releases have to happen in sync.

OncotatorProteinPosStart
OncotatorProteinPosEnd
refseqMrnaId - Has some frontend code as well

Removing oncotator fields

Backend changes:

  • web/src/main/java/org/cbioportal/web/mixin/MutationMixin.java

  • web/src/main/java/org/cbioportal/web/parameter/sort/MutationSortBy.java

  • core/src/test/java/org/mskcc/cbio/portal/dao/TestDaoMutation.java

  • core/src/main/java/org/mskcc/cbio/maf/MafRecord.java

  • core/src/main/java/org/mskcc/cbio/maf/MafUtil.java

  • core/src/main/java/org/mskcc/cbio/portal/dao/DaoMutation.java

  • core/src/main/java/org/mskcc/cbio/portal/model/ExtendedMutation.java

  • core/src/main/java/org/mskcc/cbio/portal/scripts/ImportExtendedMutationData.java

  • core/src/main/java/org/mskcc/cbio/portal/util/ExtendedMutationUtil.java

  • model/src/main/java/org/cbioportal/model/Mutation.java

  • persistence/persistence-mybatis/src/test/java/org/cbioportal/persistence/mybatis/MutationMyBatisRepositoryTest.java

  • persistence/persistence-mybatis/src/main/resources/org/cbioportal/persistence/mybatis/MutationMapper.xml

SQL

  • cgds.sql
  • cgds-test.sql
  • testSql.sql
  • core/src/test/resources/seed_mini.sql
@jagnathan jagnathan self-assigned this Aug 30, 2022
@jagnathan
Copy link
Collaborator Author

this issue is related to #9461

@jagnathan jagnathan changed the title Remove OncotatorProteinPosStart and OncotatorProteinPosEnd fields in frontend and backend Remove OncotatorProteinPosStart, OncotatorProteinPosEnd, OncotatorRefseqMrnaId fields in frontend and backend Sep 23, 2022
@jagnathan jagnathan changed the title Remove OncotatorProteinPosStart, OncotatorProteinPosEnd, OncotatorRefseqMrnaId fields in frontend and backend Remove Oncotator related fields in frontend and backend Sep 23, 2022
@jagnathan jagnathan changed the title Remove Oncotator related fields in frontend and backend Remove dbSnp* and Oncotator* related fields in frontend and backend Sep 23, 2022
@jagnathan
Copy link
Collaborator Author

ONCOTATOR_DBSNP_RS and ONCOTATOR_UNIPROT_ENTRY_NAME are always null in the cbioportal.org database.

@jagnathan
Copy link
Collaborator Author

jagnathan commented Oct 12, 2022

-- not empty ONCOTATOR_REFSEQ_MRNA_ID
-- not empty ONCOTATOR_CODON_CHANGE
-- not empty ONCOTATOR_UNIPROT_ACCESSION
-- not empty ONCOTATOR_PROTEIN_POS_START
-- not empty ONCOTATOR_PROTEIN_POS_END
-- not empty DB_SNP_RS
-- not empty DB_SNP_VAL_STATUS

Above fields have data in cbioportal.org database and therefore not removing them.

@jagnathan
Copy link
Collaborator Author

All columns that start with ONCOTATOR_ prefix replaced with MUTATION_ prefix.

@jagnathan
Copy link
Collaborator Author

In the file portal/src/org/mskcc/portal/model/MafRecord.java the prefix oncotator is replaced with prefix maf.

@stale
Copy link

stale bot commented Feb 18, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Feb 18, 2023
@dippindots
Copy link
Member

This is included in the v5.3.0, we can close this now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants