Add support for .vn domain #244
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vucong2409
force-pushed
the
feat/add-adapter-vn
branch
from
200c712
to
f2e4224
Compare
|
thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi guys,
As the title say this MR is to add support for
.vndomains. I usewhois.net.vnsince I can't find any public RDAP/Whois server that provide whois information related to this ccTLD.Changes in this MR:
.vndomainsrequest()func inwhois.gouseText()method instead of useresp.bodydirectly to allow adapter make changes to response body.whois.net.vnresponse time is > 2s most of the time.