Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't touch struct fields without env tag #310

Closed
corani opened this issue May 23, 2024 · 1 comment · Fixed by #318
Closed

Don't touch struct fields without env tag #310

corani opened this issue May 23, 2024 · 1 comment · Fixed by #318
Labels
bug

Comments

@corani
Copy link

corani commented May 23, 2024 •
edited
Loading

After #306 it appears all nil fields in the struct will be initialized to an empty value, even fields without an env tag.

I believe this initialization should only happen if (1) the field has an env tag and (2) the specified environment variable exists (with 1 being critical and 2 debatable).
@caarlos0
Copy link
Owner

hey, good catch!

should be fixed by #318

caarlos0 added a commit that referenced this issue Jun 19, 2024
@caarlos0
test: make sure #310 is covered too
57aa5b2 
closes #310
@caarlos0 caarlos0 added the bug label Jun 19, 2024
@caarlos0 caarlos0 mentioned this issue Jun 19, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: retract v11.0.1, gate init nil pointers caarlos0/env
2 participants
@caarlos0 @corani