Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dark mode #177

Merged
merged 28 commits into from
Jan 2, 2024
Merged

Dark mode #177

merged 28 commits into from
Jan 2, 2024

Conversation

evg4b
Copy link
Contributor

@evg4b evg4b commented Dec 22, 2023

What was added:

1. Dark theme for website:

Screen.Recording.2023-12-27.at.00.18.07.mov

2. 3 themes for charts

Pay attention:

  • The new rendering engine is not a pixel-perfect equivalent to wcharczuk/go-chart. The calculations were taken from the original library and simplified. But SVG rendering was written from scratch.
  • The main color for the line was changed to #6b63ff.

Adaptive (Adapts to your browser or system color scheme and has transparent background, try to test it) #146
Adaptive

Dark
Dark

Light
Light

3. New adaptive svg favicon.

Screen.Recording.2023-12-22.at.21.31.43.mov

4. Ability to colorize chart

According #135 was added ability to choose background/line/axis colors. Selected colors will be saved in local storage and restored next time

Screen.Recording.2023-12-26.at.22.21.05.mov

Colorpicker supports light and dark color schemes:
Screenshot 2023-12-26 at 23 17 30
Screenshot 2023-12-26 at 23 17 17

What was fixed:

1. Corner rendering issues

Before:

Screenshot 2023-12-22 at 18 14 44

After:

Screenshot 2023-12-22 at 18 16 29

Before:

Screenshot 2023-12-22 at 18 14 40 After: Screenshot 2023-12-22 at 18 16 19

Before:

Screenshot 2023-12-22 at 18 15 21

After:

Screenshot 2023-12-22 at 18 16 02

2. Added interactivity to elements

Updated colors for :active, :focus, :hover ::selection effects

Screen.Recording.2023-12-26.at.19.16.10.mov

3. Remove selection after copping (added Copied! label instead)

Screen.Recording.2023-12-26.at.23.14.03.mov

4. Fixed issue with submitting form after error and added informative not found error page

Screenshot 2023-12-27 at 00 07 09

Copy link
Owner

@caarlos0 caarlos0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a couple of typos, other than that, loved it!

thanks 🙏

static/templates/index.html Outdated Show resolved Hide resolved
static/templates/index.html Outdated Show resolved Hide resolved
@evg4b evg4b marked this pull request as ready for review December 27, 2023 04:35
@evg4b
Copy link
Contributor Author

evg4b commented Dec 27, 2023

Hello @caarlos0, I finally finished my PR.

Please review the code again because a lot has been added since your last review (chart caching, templates, js scripts, etc).
I have collected all the most important points in the PR description.

I hope you like these changes.
If you find any issues let me know, and I will try to fix them as soon as possible.

Thank you for your attention.

@caarlos0 caarlos0 merged commit dce1e80 into caarlos0:main Jan 2, 2024
1 of 2 checks passed
@caarlos0
Copy link
Owner

caarlos0 commented Jan 2, 2024

awesome work, thank you! 🙏💜

@evg4b evg4b deleted the dark-mode branch January 3, 2024 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants