fix: breaking change on major version zero only bumps minor (#93)

Co-authored-by: Gauthier Roebroeck <gauthier.roebroeck@episodesix.com>
caarlos0 · Mar 7, 2023 · 9c4dacb · 9c4dacb
1 parent ce0c298
commit 9c4dacb
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 0 deletions.
diff --git a/internal/svu/svu.go b/internal/svu/svu.go
@@ -27,6 +27,9 @@ func isPatch(log string) bool {
 
 func FindNext(current *semver.Version, forcePatchIncrement bool, log string) semver.Version {
 	if isBreaking(log) {
+		if current.Major() == 0 {
+			return current.IncMinor()
+		}
 		return current.IncMajor()
 	}
 

diff --git a/internal/svu/svu_test.go b/internal/svu/svu_test.go
@@ -72,10 +72,16 @@ func TestIsPatch(t *testing.T) {
 }
 
 func TestFindNext(t *testing.T) {
+	version0a := semver.MustParse("v0.4.5")
+	version0b := semver.MustParse("v0.5.5")
 	version1 := semver.MustParse("v1.2.3")
 	version2 := semver.MustParse("v2.4.12")
 	version3 := semver.MustParse("v3.4.5-beta34+ads")
 	for expected, next := range map[string]semver.Version{
+		"v0.4.5": FindNext(version0a, false, "chore: should do nothing"),
+		"v0.4.6": FindNext(version0a, false, "fix: inc patch"),
+		"v0.5.0": FindNext(version0a, false, "feat: inc minor"),
+		"v0.6.0": FindNext(version0b, false, "feat!: inc minor"),
 		"v1.2.3": FindNext(version1, false, "chore: should do nothing"),
 		"v1.2.4": FindNext(version1, true, "chore: is forcing patch, so should inc patch"),
 		"v1.3.0": FindNext(version1, false, "feat: inc major"),