Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Viper BindStruct hidden behind feature flag in viper >=v1.18.0 #78

Closed
1 task done
niklastreml opened this issue Jan 19, 2024 · 1 comment · Fixed by #134
Closed
1 task done

Bug: Viper BindStruct hidden behind feature flag in viper >=v1.18.0 #78

niklastreml opened this issue Jan 19, 2024 · 1 comment · Fixed by #134
Assignees
Labels
area/config Issues/PRs related to the startup/sparrow config area bug Something isn't working

Comments

@niklastreml
Copy link
Contributor

Is there an existing issue for this?

  • I have searched the existing issues

Current Behavior

We need to be careful when updating viper beyond v1.18.0

#73 (comment)

We should write a test case that checks whether marshalling from env variables works properly everywhere, so that we notice when someone updates the library and breaks it.

Expected Behavior

To fix this, we need to update our build and test pipelines to include the feature flag -tags=viper_bind_struct

Steps To Reproduce

No response

Relevant logs and/or screenshots, environment information, etc.

No response

Who can address the issue?

Anyone

Anything else?

No response

@niklastreml niklastreml added the bug Something isn't working label Jan 19, 2024
@lvlcn-t lvlcn-t added the area/config Issues/PRs related to the startup/sparrow config area label Jan 19, 2024
@lvlcn-t lvlcn-t self-assigned this May 6, 2024
@lvlcn-t
Copy link
Member

lvlcn-t commented Jun 9, 2024

The build constraint can be removed as soon as spf13/viper#1854 made it into a new release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/config Issues/PRs related to the startup/sparrow config area bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants