Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add experimental flag for bind struct #1854

Merged
merged 2 commits into from
Jun 5, 2024
Merged

Conversation

sagikazarmark
Copy link
Collaborator

Fixes #1851
Fixes #1721

Signed-off-by: Mark Sagi-Kazar <mark.sagikazar@gmail.com>
Signed-off-by: Mark Sagi-Kazar <mark.sagikazar@gmail.com>
@sagikazarmark sagikazarmark added the kind/enhancement New feature or request label Jun 4, 2024
Copy link

github-actions bot commented Jun 4, 2024

👋 Thanks for contributing to Viper! You are awesome! 🎉

A maintainer will take a look at your pull request shortly. 👀

In the meantime: We are working on Viper v2 and we would love to hear your thoughts about what you like or don't like about Viper, so we can improve or fix those issues.

⏰ If you have a couple minutes, please take some time and share your thoughts: https://forms.gle/R6faU74qPRPAzchZ9

📣 If you've already given us your feedback, you can still help by spreading the news,
either by sharing the above link or telling people about this on Twitter:

https://twitter.com/sagikazarmark/status/1306904078967074816

Thank you! ❤️

@sagikazarmark sagikazarmark merged commit d1e18b2 into master Jun 5, 2024
29 checks passed
@sagikazarmark sagikazarmark deleted the experimental-bind-struct branch June 5, 2024 11:35
@andig
Copy link
Contributor

andig commented Jun 7, 2024

Love it- much simpler to use than the compile switches. Doesn't this also replace #1715? Wondering why that's not visible in the diff? However, it's not possible to use with the global viper instance, right?

@sagikazarmark
Copy link
Collaborator Author

The build tag didn't go away. You can still set it which means it's going to be enabled by default for every Viper instance. Or you can enable it on a case-by-case basis using the option.

@haoming29
Copy link

haoming29 commented Jun 24, 2024

Is there a way to enable this feature with the global instance other than doing the build flag? Thanks!
UPDATE: nvm, found in #1856

haoming29 added a commit to haoming29/pelican that referenced this pull request Jun 24, 2024
jhiemstrawisc pushed a commit to PelicanPlatform/pelican that referenced this pull request Jun 25, 2024
haoming29 added a commit to haoming29/pelican that referenced this pull request Jun 28, 2024
patrickbrophy pushed a commit to patrickbrophy/pelican that referenced this pull request Jul 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement New feature or request
Projects
None yet
3 participants