Added Litematica support #2544

EmersonDove · 2021-03-07T16:03:39Z

Added litematica support to 1.12.2 master.

Issues with this version:

Some states (such as iron bars) are unrecognized
In 1.12, the long array (blockstates) isn't exposed by the libraries so parsing has to be done manually
Only reads in first region of the .litematic

#2338 Is a fully working implementation for modern versions of MC

If anyone has knowledge or cleaner solutions for any of these leave a comment so I can update it.

scorbett123 · 2021-03-07T17:57:04Z

src/main/java/baritone/utils/schematic/format/defaults/LitematicaSchematic.java

+        public static long roundUp(long number, long interval)
+        {
+            if (interval == 0)
+            {
+                return 0;
+            }
+            else if (number == 0)
+            {
+                return interval;
+            }
+            else
+            {
+                if (number < 0)
+                {
+                    interval *= -1;
+                }
+
+                long i = number % interval;
+                return i == 0 ? number : number + interval - i;
+            }
+        }


Suggested change

public static long roundUp(long number, long interval)

{

if (interval == 0)

{

return 0;

}

else if (number == 0)

{

return interval;

}

else

{

if (number < 0)

{

interval *= -1;

}

long i = number % interval;

return i == 0 ? number : number + interval - i;

}

}

public static long roundUp(double number, long interval)

{

if (number < 0){

interval *= -1;

}

return interval * (long) Math.ceil(number/interval);

}

I believe that this has exactly the same functionality, if you have any reason for wanting to use this instead please do, however I think this is nicer,

No, it will throw an exception instead of returning 0 if interval is 0 and if number is 0 it returns 0 instead of number.

I don't believe that interval is ever 0, the only occurrence I could found was that it was 64.

I can test it. The nested class there is straight out of litematica, so I just left the code as-is.

ZacSharp · 2021-03-07T21:32:56Z

src/main/java/baritone/utils/schematic/format/defaults/LitematicaSchematic.java

+        // In 1.12, the long array isn't exposed by the libraries so parsing has to be done manually
+        String rawBlockString = (nbt.getCompoundTag("Regions").getCompoundTag(regionName)).getTag("BlockStates").toString();
+        rawBlockString = rawBlockString.substring(3,rawBlockString.length()-1);
+        String[] rawBlockArrayString = rawBlockString.split(",");
+        long[] rawBlockData = new long[rawBlockArrayString.length];
+        for (int i = 0; i < rawBlockArrayString.length; i++) {
+            rawBlockData[i] = Long.parseLong(rawBlockArrayString[i].substring(0,rawBlockArrayString[i].length()-1));
+        }


Since I hate parsing strings that aren't meant to be parsed, may I suggest using reflection or mixin to access the data attribute? I checked the litematica and malilib sources and the latter is what is used there.

Yes so that's the main reason why I have this as a draft pull because that iteration is so tacky. I'll look into those sources and try to find something.

ZacSharp · 2021-03-07T21:35:12Z

src/main/java/baritone/utils/schematic/format/defaults/LitematicaSchematic.java

+public final class LitematicaSchematic extends StaticSchematic {
+
+    public LitematicaSchematic(NBTTagCompound nbt) {
+        String regionName = (String) nbt.getCompoundTag("Regions").getKeySet().toArray()[0];


Why not iterate over all regions?
They are all part of the schematic and the issues would just be spammed with "Baritone not loading some litematic regions"

Good point, I didn't do it because it involves reading the entire schematic into a larger volume. It makes more sense to add a region argument to the command? Going to add it to my initial issues list.

I think it would be better to just keep the sub-regions, just like CompositeSchematic does it with it's sub-schematics.

Sounds good, I'll look into that one too.

ZacSharp · 2021-05-10T20:56:09Z

@EmersonDove are you still working on this?

EmersonDove · 2021-05-11T15:21:07Z

@ZacSharp I've been on and off about it. I haven't fixed any the original bugs enough to commit. I talked to masa and he believes it should be possible but in general the 1.12.2 port has had a lot of issues.
I'll probably give it another try after the semester is over.

sudofox · 2021-10-25T17:33:24Z

I'd like to express my interest here as well -- I have a lot of complex redstone that I need to place (running experimental 1.17.1 build) and this would make life much easier for me

sudofox · 2022-02-10T20:57:14Z

I ported this up to 1.17 a while ago here, did the work translating mappings etc

https://raw.githubusercontent.com/sudofox/baritone-1.17/master/src/main/java/baritone/utils/schematic/format/defaults/LitematicaSchematic.java?token=GHSAT0AAAAAABKUY4TPGPDW7HIUI2M37YD2YQLEGKA

Unsure what needs to be done to push things forward

ZacSharp · 2022-02-10T23:23:23Z

Issues with this version:

Some states (such as iron bars) are unrecognized

In 1.12, the long array (blockstates) isn't exposed by the libraries so parsing has to be done manually

Only reads in first region of the .litematic

I't probably useable as is (never managed to get myself to have a look at it), but not ready for merging. The reason for the first point is unknown (as far as I know), the other two points have already been addressed in the discussion here.

EmersonDove · 2022-02-11T01:07:30Z

Hey everyone looks like I should follow up here -

I wouldn't feel good merging it in with its current state - I would expect this will create GH issues than are closed.

I'm interested in pushing things forward for a 1.12 implementation with @sudofox but hit a wall with the mixins and have been working on other projects (@blankly-finance). I talked to Mesa a few months ago and there is no technical reason why this couldn't work.

If someone could tackle or give some pointers on the mixin for the long array that would be great.

ZacSharp · 2022-02-13T15:41:55Z

For the mixin you probably want a simple mixin on NBTTagLongArray with an @Accessor for the data field. Since Baritone has the mixin classes in a separate source set you also need an interface for the accessor in the main source set and make the mixin class implement it. If you've got it right you can then safely cast the long array to the accessor interface and youse the mixin generated method to get the data. I think the easiest way to see how to do it is looking at the interfaces in baritone.utils.accessor and their implementations in baritone.launch.mixins.

sudofox · 2022-02-13T15:53:43Z

Thanks for the mention Emerson. I should establish that my Java skills are quite hodgepodgey so I'll try to contribute as much as I can but otherwise I'll cheer you on from the sidelines 😅

maruohon · 2022-02-15T09:34:51Z

src/main/java/baritone/utils/schematic/format/defaults/LitematicaSchematic.java

+
+    public LitematicaSchematic(NBTTagCompound nbt) {
+        String regionName = (String) nbt.getCompoundTag("Regions").getKeySet().toArray()[0];
+        this.x = Math.abs(nbt.getCompoundTag("Regions").getCompoundTag(regionName).getCompoundTag("Size").getInteger("x"));


The region size needs to be handled differently. The stored sizes per axis can be negative, if the "primary corner" (region origin) is not in the minimum corner of the region. (If they are negative, then they are at max -2, there should be no -1 values created by Litematica, as that is essentially the same as positive 1.)

I think for Baritone you can basically just use Math.abs() and then offset the origin if the values were negative for some axes. (No idea how you handle the positioning, and if you have rotations, but if you read everything into one large block container then it doesn't matter at this level anyway.) In Litematica this "freedom" in creating the selection with the primary corner in any relative corner causes quite some mess and complexity when handling the regions with rotations and mirroring etc.

We always use the minimum corner for the position and don't have rotations, so (once we read more than the first region) just adding size + 1 and then removing the sign from size should work fine.

ZacSharp · 2022-03-03T16:19:02Z

I've had a look at it and I think you can copy the changes from ZacSharp@0550fe3 as is. I also had a try at loading all regions of the schematic in ZacSharp@3cf9e2f but that commit is not useable as is and comes with debug printouts and will likely (didn't try it) crash with map art mode enabled for any litematic that does completely fill its enclosing box volume.

ZacSharp · 2022-03-31T22:42:29Z

I've invested some more time and used the approach from #3317 (patching the holes with air) to fix mapArtMode. You can find the changes at ZacSharp@3661fea and its parents in case you want to use them.

ZacSharp · 2022-03-31T22:44:46Z

I also failed to reproduce the bug with iron bars not being loaded correctly, all 16 worked.

ThalusA · 2022-05-28T18:27:51Z

What does this PR still need to get released?

amatheo · 2022-08-10T15:59:43Z

News on why there is still no merge ?

ehylo · 2022-08-10T16:04:01Z

It's a draft? it isn't finished yet if you couldn't tell

ZacSharp · 2022-08-27T02:49:30Z

What's currently missing (both done on my branch but @EmersonDove hasn't done it here yet)

Read all regions of the .litematic instead of just the first
Get rid of the hacky string parsing

@leijurv I'd really like to know whether static schematics are allowed to have holes (i.e. behavior of getDirect is undefined at positions within the schematic bounds as it is the case for other schematics).

scorbett123 · 2022-10-03T20:10:40Z

Superseded by #3672

Added Litematica support

5d7128b

StoneCommander mentioned this pull request Mar 7, 2021

1.16.4 - Full Litematica Building Support #2338

Closed

scorbett123 reviewed Mar 7, 2021

View reviewed changes

ZacSharp reviewed Mar 7, 2021

View reviewed changes

ZacSharp mentioned this pull request Mar 11, 2021

Litematica #2555

Closed

scorbett123 mentioned this pull request Apr 28, 2021

Support for Litematica in Minecraft 1.16.5 #2701

Closed

ZacSharp mentioned this pull request Aug 9, 2021

make baritone work with litematica #2928

Closed

wagyourtail mentioned this pull request Dec 20, 2021

Litematica Support. #3156

Closed

maruohon reviewed Feb 15, 2022

View reviewed changes

ZacSharp mentioned this pull request Feb 15, 2022

#build .litematic support (and #create ?) #668

Closed

ZacSharp mentioned this pull request Apr 17, 2022

How to Build a Litematic Without All The Materials Required? #3397

Closed

wagyourtail mentioned this pull request Apr 27, 2022

Baritone cant load files with .litematica #3421

Closed

ZacSharp mentioned this pull request Sep 24, 2022

Rework of @Emerson 1.12 litematica port for 1.18.2 fabric #3669

Closed

rycbar0 mentioned this pull request Sep 26, 2022

Litematica Support for bariton #3672

Merged

scorbett123 closed this Oct 3, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Added Litematica support #2544

Added Litematica support #2544

EmersonDove commented Mar 7, 2021 •

edited

Loading

scorbett123 Mar 7, 2021

ZacSharp Mar 7, 2021

scorbett123 Mar 7, 2021

EmersonDove Mar 7, 2021

ZacSharp Mar 7, 2021

EmersonDove Mar 7, 2021

ZacSharp Mar 7, 2021

EmersonDove Mar 7, 2021 •

edited

Loading

ZacSharp Mar 7, 2021

EmersonDove Mar 7, 2021

ZacSharp commented May 10, 2021

EmersonDove commented May 11, 2021

sudofox commented Oct 25, 2021

sudofox commented Feb 10, 2022

ZacSharp commented Feb 10, 2022

EmersonDove commented Feb 11, 2022

ZacSharp commented Feb 13, 2022

sudofox commented Feb 13, 2022

maruohon Feb 15, 2022 •

edited

Loading

ZacSharp Feb 15, 2022 •

edited

Loading

ZacSharp commented Mar 3, 2022

ZacSharp commented Mar 31, 2022

ZacSharp commented Mar 31, 2022

ThalusA commented May 28, 2022

amatheo commented Aug 10, 2022

ehylo commented Aug 10, 2022

ZacSharp commented Aug 27, 2022

scorbett123 commented Oct 3, 2022

Added Litematica support #2544

Added Litematica support #2544

Conversation

EmersonDove commented Mar 7, 2021 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

EmersonDove Mar 7, 2021 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ZacSharp commented May 10, 2021

EmersonDove commented May 11, 2021

sudofox commented Oct 25, 2021

sudofox commented Feb 10, 2022

ZacSharp commented Feb 10, 2022

EmersonDove commented Feb 11, 2022

ZacSharp commented Feb 13, 2022

sudofox commented Feb 13, 2022

maruohon Feb 15, 2022 • edited Loading

Choose a reason for hiding this comment

ZacSharp Feb 15, 2022 • edited Loading

Choose a reason for hiding this comment

ZacSharp commented Mar 3, 2022

ZacSharp commented Mar 31, 2022

ZacSharp commented Mar 31, 2022

ThalusA commented May 28, 2022

amatheo commented Aug 10, 2022

ehylo commented Aug 10, 2022

ZacSharp commented Aug 27, 2022

scorbett123 commented Oct 3, 2022

EmersonDove commented Mar 7, 2021 •

edited

Loading

EmersonDove Mar 7, 2021 •

edited

Loading

maruohon Feb 15, 2022 •

edited

Loading

ZacSharp Feb 15, 2022 •

edited

Loading