Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestion #4021

Closed
wants to merge 3 commits into from
Closed

Suggestion #4021

wants to merge 3 commits into from

Conversation

rycbar0
Copy link
Contributor

@rycbar0 rycbar0 commented Jun 23, 2023

a suggestion on how to fix #4020

@ZacSharp
Copy link
Collaborator

This does certainly fix both issues (you can also add a "fix" or "fixes" for #3000 and #3409), but I don't like the way you fixed the "only pickaxes are moved" problem.

To fix the "don't move items you don't need" issue properly we have to move items only when we know we actually need them, because otherwise this fix is just going to result in follow up bug reports where people complain it insists on having a pickaxe even though allowBreak is off or it moves tools even though no blocks in allowBreakAnyway are in render distance or it moves stone with allowPlace disabled or it doesn't choose the correct super-hyper-spade from whatever-mod because that spade only works for blocks from whatever-mod or it doesn't move shears to hotbar to break leaves (same for hoes and swords).
What we need is a general purpose item selection method like InventoryBehavior.throwaway which can also select items by priority. The intention behind using general priority based selection rather than specialized tool selection is that e.g. ElytraBehavior also have use for this. It currently prioritizes boosting fireworks by trying to get some and if that fails it tries to get fireworks without boost. Prioritizing longer boosts would currently require two more queries (because there's 3 boost lengths) or duplicating the logic.
.

@ZacSharp
Copy link
Collaborator

Just noticed I said that I didn't like one fix and then went on about the other, oops.
Guess that's because I really want on demand selection, which is a fix to both the hotbar space problem (3 tools + throwaway is 4 slots before it even started working on a task) and the various cases where it still won't move the tool or still would move the tool way too eagerly (i.e. if it can't possibly need it).

@rycbar0
Copy link
Contributor Author

rycbar0 commented Aug 23, 2023

no longer relevant

@rycbar0 rycbar0 closed this Aug 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Baritone only moves pickaxes and throwaway blocks to the hot bar and does that even if no process is active
3 participants