Skip to content

Commit

Permalink
v0.2.1 Fix ImagePuller authentication
Browse files Browse the repository at this point in the history
We were serializing the wrong struct, and since we're not testing the
auth in the open source version, that went unnoticed.

We really need an authenticated build / gitlab CI job for this one.
  • Loading branch information
colega committed Nov 18, 2020
1 parent 7604291 commit 1264f99
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 1 deletion.
4 changes: 4 additions & 0 deletions CHANGELOG.md
Expand Up @@ -6,6 +6,10 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

## [Unreleased]

## [0.2.1] - 2020-11-18
### Fixed
- `ImagePuller` authentication.

## [0.2.0] - 2020-11-18
### Changed
- BREAKING: `aceptadora.New()` now accepts an `ImagePuller` instead of creating it, and `aceptadora.Config` no longer contains the `aceptadora.ImagePullerConfig`.
Expand Down
2 changes: 1 addition & 1 deletion puller.go
Expand Up @@ -89,7 +89,7 @@ func (i *ImagePullerImpl) tryPullImage(ctx context.Context, imageName string) er

var authStr string
if ok {
encodedJSON, err := json.Marshal(repoCfg)
encodedJSON, err := json.Marshal(repoCfg.Auth)
if err != nil {
return fmt.Errorf("encoding JSON auth: %v", err)
}
Expand Down

0 comments on commit 1264f99

Please sign in to comment.