Add objectives to summaries from struct tag #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juananrey
approved these changes
Oct 10, 2019
mapno
force-pushed
the
pass-objectives-to-summaries
branch
2 times, most recently
from
38678ae
to
0dba6ec
Compare
colega
approved these changes
Oct 10, 2019
mapno
force-pushed
the
pass-objectives-to-summaries
branch
from
0dba6ec
to
ff8df00
Compare
Prometheus has deprecated the default values for objectives and they now need to be explicitly specified. Default values are those that client_golang library had before deprecation in v1. If no objectives are specified, default objectives are used.
mapno
force-pushed
the
pass-objectives-to-summaries
branch
from
ff8df00
to
e5ec03d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prometheus has deprecated the default values for objectives and they now need to be explicitly specified.
Default values are those that client_golang library had before deprecation in v1.
If no objectives are specified, default objectives are used.
Solves https://github.com/cabify/gotoprom/issues/20.