Histograms: require buckets to be explicit #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Default buckets were removed and buckets are now required: writing the buckets is a 5 second effort while forgetting about them and having wrong buckets in production is a lot of work (and maybe even an incident if wrong buckets don't provide enough visibility on an issue) So now any code without buckets on the histograms will fail to intialize that metrics. Finally, empty buckets tag is now allowed and it builds an empty buckets slice, which will cause prometheus library to use its own default buckets. Notice that this change identified an issue in one of our own tests where buckets tag was wrong (`metricsbuckets`) and it was unnoticed because default buckets where used instead.
colega
force-pushed
the
colega/remove-default-buckets
branch
from
553f04c
to
a33793f
Compare
mapno
approved these changes
Jan 9, 2020
colega
added a commit
that referenced
this pull request
Jan 9, 2020
Just like #27 for Histograms, summaries now should be built with explicit objectives or their building will fail.
colega
added a commit
that referenced
this pull request
Jan 9, 2020
Just like #27 but for Summaries, same reasons apply, TL;DR: explicit is better than implicit. Also fixed summary builder not failing when objectives were malformed.
colega
added a commit
that referenced
this pull request
Jan 9, 2020
Just like #27 but for Summaries, same reasons apply, TL;DR: explicit is better than implicit. Also fixed summary builder not failing when objectives were malformed.
colega
added a commit
that referenced
this pull request
Jan 9, 2020
Just like #27 but for Summaries, same reasons apply, TL;DR: explicit is better than implicit. Also fixed summary builder not failing when objectives were malformed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Default buckets were removed and buckets are now required: writing the buckets is a 5 second effort while forgetting about them and having wrong buckets in production is a lot of work (and maybe even an incident if wrong buckets don't provide enough visibility on an issue)
So now any code without buckets on the histograms will fail to intialize that metrics.
Finally, empty buckets tag is now allowed and it builds an empty buckets slice, which will cause prometheus library to use its own default buckets.
Notice that this change identified an issue in one of our own tests where buckets tag was wrong (
metricsbuckets) and it was unnoticed because default buckets where used instead.Solves https://github.com/cabify/gotoprom/issues/23