Skip to content

Commit

Permalink
Check how clients are being shown on the dashboard
Browse files Browse the repository at this point in the history
the new client work is almost ready, but unfortunately they don't show up on the dashboard. I've added some debugging language, and turned off production deploys so that sensitive data doesn't get shown to users
  • Loading branch information
jonodrew committed Jun 21, 2024
1 parent e29e176 commit 2b6b107
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 5 deletions.
8 changes: 4 additions & 4 deletions .github/workflows/main.yml
Original file line number Diff line number Diff line change
Expand Up @@ -27,10 +27,10 @@ jobs:
SERVICE_DOMAIN: sso.nonprod-service.security.gov.uk
TF_WORKSPACE: nonprod
AWS_REGION: eu-west-2
- environment: prod-aws
SERVICE_DOMAIN: sso.service.security.gov.uk
TF_WORKSPACE: prod
AWS_REGION: eu-west-2
# - environment: prod-aws
# SERVICE_DOMAIN: sso.service.security.gov.uk
# TF_WORKSPACE: prod
# AWS_REGION: eu-west-2
environment:
name: ${{ matrix.environment }}
steps:
Expand Down
2 changes: 2 additions & 0 deletions templates/dashboard.html
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,9 @@ <h2 class="govuk-heading-l">Dashboard</h2>
<h2 class="govuk-heading-l">Applications</h2>
<div>
{%- if allowed_apps %}
<p>{{ allowed_apps }}</p>
{%- for a in allowed_apps %}
<p>{{ a }}</p>
{%- set app = allowed_apps[a] %}
{%- if app["name"] and ((app["sign_in_url"] and app["dashboard_display"]) or app["can_manage"]) %}
<div>
Expand Down
2 changes: 1 addition & 1 deletion wsgi.py
Original file line number Diff line number Diff line change
Expand Up @@ -1414,7 +1414,7 @@ def new_client():
request_dict = request.form.to_dict()
sso_oidc.save_client(
filename=f"{request_dict['app_url']}_{uuid.uuid4().hex}.json",
client={"secret": client_secret, "dashboard_display": True, **request_dict},
client={"secret": client_secret, **request_dict},
client_id=client_id
)
return redirect(f"/view?client_id={client_id}")
Expand Down

0 comments on commit 2b6b107

Please sign in to comment.