Ensure rejected connections are not stored - which causes memory leaks #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Marc Jeffrey <mjeffrey18@gmail.com>
Signed-off-by: Marc Jeffrey <mjeffrey18@gmail.com>
- to avoid memory - also some minor syntax cleanup Signed-off-by: Marc Jeffrey <mjeffrey18@gmail.com>
Signed-off-by: Marc Jeffrey <mjeffrey18@gmail.com>
Signed-off-by: Marc Jeffrey <mjeffrey18@gmail.com>
jwoertink
requested changes
Nov 6, 2021
There was a problem hiding this comment.
This is amazing stuff! Thanks so much for taking this on. It's a pretty big PR, so I want to make sure I really go over it. I left a few suggestions, but only real change I think is to just leave the version alone for now. Otherwise I'm open to your input on the other things.
Signed-off-by: Marc Jeffrey <mjeffrey18@gmail.com>
jwoertink
reviewed
Nov 7, 2021
| @@ -1,84 +1,54 @@ | |||
| require "uuid" | |||
|
|
|||
| module Cable | |||
| class Connection | |||
| abstract class Connection | |||
There was a problem hiding this comment.
I think this makes sense. What do you think @fernandes?
There was a problem hiding this comment.
yes, totally, specially because this class should never get instantiated itself.. way better! 👍
fernandes
approved these changes
Nov 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
I found a memory leak in production due to unathorised connections still being stored on the
Cable::Server#connectionshash.Implementation
reject_connection!helper methods to connection class and use this to ensure rejected connections are never added to theCable::Server#connectionshashidentified_by(field)can be used with a different key other thanidentifierwhile still providing access viaconnection.identifierconnect.reject(channel : Cable::Channel)to instead supportconnection.reject(payload : Cable::Payload)keeping it consistent with the other methods likesubscribe, unsubscribe and message