Allow subscribing to the same channel once from a connection #36
Conversation
Signed-off-by: Marc Jeffrey <mjeffrey18@gmail.com>
…nnection Signed-off-by: Marc Jeffrey <mjeffrey18@gmail.com>
It will work fine with refreshes and across browser windows and tabs, we have 1 app with some legacy code that creates 2 connections and subscribed to different channels - all good. Plus we have opened dozens of tabs, windows etc and they all get a new connection and can subscribe without issue with these changes. We just need to protect the server from accepting many subscriptions on the same channel via the same connection as it won't do the server any good and also the client will just get duplicate messages so not useful to anyone. Better to stick with what rails does and just ignore the client if it makes those mistakes. |
| @@ -24,16 +24,13 @@ describe Cable::Connection do | |||
|
|
|||
| it "accepts without params hash key" do | |||
| connect do |connection, socket| | |||
| connection.receive({"command" => "subscribe", "identifier" => {channel: "ChatChannel", room: "1"}.to_json}.to_json) | |||
There was a problem hiding this comment.
took me a while to figure out about this change, then I read the test description 🤦♂️ lol
Purpose
To keep close to the ActionCable way of doing things, this change gets us a step closer.
The problem
Rails doesn't allow the same connection to subscribe to the same channel many times.
Cable.cr does at the moment, unfortunately.
It actually causes unnecessary memory bloat by allowing the same client connection to get connected many times, receiving many of the same broadcasted messages also
Solution
Silently do nothing if the client makes this mistake. This is exactly what rails does...
Works perfectly.