Updates on IP address and prefix representation #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cabo
approved these changes
Jan 18, 2024
draft-bormann-cbor-yang-standin.md
Outdated
| Addresses that have zones given cannot use tag 54/52. | ||
| Addresses with leading zeros cannot use tag 54/52. | ||
| Addresses that do not comply with {{RFC5952}} cannot use tag 54. | ||
| The encoder MAY normalize IPv6 addresses and prefixes that do not comply with {{RFC5952}} |
There was a problem hiding this comment.
I don't think I know what an encoder is here.
The conversion from stand-in tag to a legacy representation?
There was a problem hiding this comment.
Added a definition to the top.
draft-bormann-cbor-yang-standin.md
Outdated
| Addresses with leading zeros cannot use tag 54/52. | ||
| Addresses that do not comply with {{RFC5952}} cannot use tag 54. | ||
| The encoder MAY normalize IPv6 addresses and prefixes that do not comply with {{RFC5952}} | ||
| but can be converted into the stand-in representation. The encoder implementation SHOULD be clear |
There was a problem hiding this comment.
We tend not to use RFC 2119 keywords for documentation requirements.
There was a problem hiding this comment.
Fixed, thanks. (This is my first RFC, please be patient.)
draft-bormann-cbor-yang-standin.md
Outdated
| but can be converted into the stand-in representation. The encoder implementation SHOULD be clear | ||
| about whether this normalization is employed or not. | ||
|
|
||
| If the schema specifies `ip-prefix`, the encoder MAY normalize prefixes with |
There was a problem hiding this comment.
normalize with or prefixes with? (Maybe an in-line example would clarify this.)
There was a problem hiding this comment.
clarified, hopefully
cabo
reviewed
Jan 18, 2024
draft-bormann-cbor-yang-standin.md
Outdated
|
|
||
| If the schema specifies a union between `ip-prefix` and `ip-address-and-prefix` (or a union of their subtypes), | ||
| the encoder MUST prefer the `ip-address-and-prefix` stand-in over `ip-prefix` | ||
| format. Specifically, it the schema allows to encode 2001:db8:1234::/48 both as |
There was a problem hiding this comment.
Suggested change
| format. Specifically, it the schema allows to encode 2001:db8:1234::/48 both as | |
| format. Specifically, if the schema allows to encode 2001:db8:1234::/48 both as |
cabo
reviewed
Jan 18, 2024
draft-bormann-cbor-yang-standin.md
Outdated
| non-zero bits after the prefix end. The encoder implementation SHOULD be clear | ||
| about whether this normalization is employed or not. | ||
|
|
||
| If the schema specifies a union between `ip-prefix` and `ip-address-and-prefix` (or a union of their subtypes), |
There was a problem hiding this comment.
We probably need to address unions in general.
Put in #2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.