Make Multilevel adapter apply deletes in reverse order #174
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the order of delete operations in the Multilevel adapter. Consider the following scenario:
So we end up with stale key in L1 after delete.
In order to fix this it would make sense to perform deletes in reverse order, i.e. from L2 to L1. I figured out there are 3 callbacks affected:
delete
,take
anddelete_all
.Please let me know what you think!