fix: Dialyzer useless control flow #73
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
cabol
reviewed
Jun 11, 2020
There was a problem hiding this comment.
First of all, thanks a lot for this great contribution, actually I was facing the same issue, but I couldn't dig that much into it. I just let you a couple of comments, silly ones, and also in order to fix the CI, run mix format as well, actually, in order to be sure the CI will pass, you can run before:
mix coveralls.html (expected 100%).
mix format
mix credo --strict
mix dialyzer
Again, thanks a lot, and looking forward to the fixes so we can merge it 😄 !!
cabol
added a commit
that referenced
this pull request
Jun 14, 2020
cabol
added a commit
that referenced
this pull request
Jul 5, 2020
Crafting Nebulex v2 * Cache API v2 (Refactoring) * Support for ETS table types * Overall enhancements on docs and adapters * Add CI cache and fix dialyzer * Validate size by the number cached entries via `:max_size` option * Improvements on cache-decorators * Caching and Hook decorators improvements * Adding adapter metadata * Add dynamic cache feature (based on Ecto dynamic repo) Improve local adapter to manage only two generations and use persistent_term Fix adapters for handling metadata Fix docs * Fix docs and bench * Overall fixes * Apply the fix for the issue #73 in Nebulex.Caching * Add stats support via Erlang Counters * Adapter improvements * Improve stats support * Add guides `migrating-to-v2` and `telemetry` * Overall improvements
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue: #74