Fix parse_cluster_info in RedisCluster.ConfigManager #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cabol
reviewed
Jul 31, 2023
|
Hi @cabol. Any prevision to next release with this fix? |
|
Sure, will release it in the next few days (coming weekend)! |
|
Nicee, very thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I came across this problem when trying to use the cluster mode. I realized that the lib wasn't considering the optional fields that can be present in the data returned by the "CLUSTER SHARDS" command (tls-port and hostname), which in the code the info are extracted through a pattern matching operation that when these optional fields are present doesn´t match the expected, leading to lost the data and returning an empty list.
I was able to handle that as seen in the changes but I wasn't able to write the tests successfully. @cabol could you help with the tests if all I said makes any sense?