Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

stop using shell=True for local build runs #36

Merged
merged 1 commit into from Sep 13, 2023
Merged

stop using shell=True for local build runs #36

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
8 changes: 4 additions & 4 deletions cabotage/celery/tasks/build.py
View file
Open in desktop
Expand Up @@ -312,9 +312,9 @@ def build_release_buildkit(release):
f.write(dockerconfigjson)
try:
completed_subprocess = subprocess.run(
" ".join(buildctl_command + buildctl_args),
buildctl_command + buildctl_args,
env={'BUILDKIT_HOST': buildkitd_url, 'HOME': tempdir},
shell=True, cwd=tempdir, check=True,
cwd=tempdir, check=True,
stdout=subprocess.PIPE, stderr=subprocess.STDOUT, text=True,
)
except subprocess.CalledProcessError as exc:
Expand Down Expand Up @@ -656,9 +656,9 @@ def build_image_buildkit(image=None):
f.write(dockerconfigjson)
try:
completed_subprocess = subprocess.run(
" ".join(buildctl_command + buildctl_args),
buildctl_command + buildctl_args,
env={'BUILDKIT_HOST': buildkitd_url, 'HOME': tempdir},
shell=True, cwd="/tmp", check=True,
cwd="/tmp", check=True,
stdout=subprocess.PIPE, stderr=subprocess.STDOUT, text=True,
)
except subprocess.CalledProcessError as exc:
Expand Down