Remove minio driver/extension, disable image builds from tarball #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With migration to buildkit based builds, we no longer need to retrieve the source tarball, rewrite it, and shuffle it around via minio. Thus our need for minio integration is complete. Since the image build via tarball relies on minio, just remove it.
ewdurbin
added a commit
that referenced
this pull request
Sep 18, 2023
previously we populated build_slug to shuffle around via minio
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With migration to buildkit based builds, we no longer need to retrieve the source tarball, rewrite it, and shuffle it around via minio.
Thus our need for minio integration is complete.
Since the image build via tarball relies on minio, just remove it.