Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix pre-release of keras installing #58

Merged
merged 1 commit into from Oct 8, 2021

Conversation

cabrust
Copy link
Owner

@cabrust cabrust commented Oct 8, 2021

We typically use setup.py develop to install dependencies, however this sometimes pulls pre-releases. Currently, it installs keras==2.7rc0 which is broken. This PR switches everything to pip install -e ., which is also used in the test cases, and also fixes the Python version specs in the actions to avoid confusion later on.

@cabrust cabrust added the bug Something isn't working label Oct 8, 2021
@cabrust cabrust self-assigned this Oct 8, 2021
@codecov-commenter
Copy link

codecov-commenter commented Oct 8, 2021

Codecov Report

Merging #58 (383e8ec) into main (2ad4b90) will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main      #58   +/-   ##
=======================================
  Coverage   65.50%   65.50%           
=======================================
  Files          79       79           
  Lines        3180     3183    +3     
  Branches      494      494           
=======================================
+ Hits         2083     2085    +2     
- Misses       1010     1011    +1     
  Partials       87       87           
Impacted Files Coverage Δ
chia/helpers/ioqueue.py 19.64% <0.00%> (-0.36%) ⬇️
chia/helpers/better_ioqueue.py 79.68% <0.00%> (+0.65%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2ad4b90...383e8ec. Read the comment docs.

@cabrust cabrust merged commit 007f9e7 into main Oct 8, 2021
@cabrust cabrust deleted the fixes/keras-prerelease-is-installed branch October 8, 2021 07:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants