Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pre-commit directive no longer works #1024

Closed
dz0ny opened this issue Mar 21, 2024 · 2 comments
Closed

pre-commit directive no longer works #1024

dz0ny opened this issue Mar 21, 2024 · 2 comments
Labels
bug Something isn't working

Comments

@dz0ny
Copy link
Contributor

dz0ny commented Mar 21, 2024

Describe the bug
Adding a simple pre-commit hook yield's in flake build error.

To reproduce

  pre-commit.hooks = {
    shellcheck.enable = true;
  };

Error:

error:
       … while calling the 'derivationStrict' builtin

         at /builtin/derivation.nix:9:12: (source not available)

       … while evaluating derivation 'devenv-shell'
         whose name attribute is located at /nix/store/bv68i4l7g6s5sixxm0c9lcjdxhlkg0n5-source/pkgs/stdenv/generic/make-derivation.nix:331:7

       … while evaluating attribute 'DEVENV_PROFILE' of derivation 'devenv-shell'

         at «none»:0: (source not available)

       (stack trace truncated; use '--show-trace' to show the full trace)

       error: attribute 'enabledPackages' missing

       at /nix/store/c8kfbl8b8z0gxzwy0xs29hgw1y13fy2w-source/src/modules/integrations/pre-commit.nix:26:49:

           25|     '';
           26|     packages = [ config.pre-commit.package ] ++ config.pre-commit.enabledPackages;
             |                                                 ^
           27|     enterShell = config.pre-commit.installationScript;

Version

Paste the output of $ devenv version here.

@dz0ny dz0ny added the bug Something isn't working label Mar 21, 2024
@domenkozar
Copy link
Member

Did you update pre-commit input?

@dz0ny
Copy link
Contributor Author

dz0ny commented Mar 21, 2024

Did you update pre-commit input?

Yep, testin 1.0 :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants