Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add link to new map site for candidates #430

Merged
merged 1 commit into from
Nov 2, 2020
Merged

Conversation

anlawyer
Copy link
Member

This work resolves #429.

I also moved the "Get alerts" section to the bottom of the candidate page, which resolves #410.

I also added a table icon to the "See all contributions" link, to align with the styles of the other links on the candidate page... but I can remove that if we want.

Large screens
Screen Shot 2020-10-28 at 10 13 28 AM

Copy link
Contributor

@ckingbailey ckingbailey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks grape! 🍇👀

@ckingbailey
Copy link
Contributor

In checking this out locally, I noticed that Rebecca Kaplan's map link goes to wrong candidate's map view (sp., Derrick Johnson's). I'm sure that comes out of the spreadsheet. I'm gonna quickly comb through and look for other boo-boos

@anlawyer
Copy link
Member Author

In checking this out locally, I noticed that Rebecca Kaplan's map link goes to wrong candidate's map view (sp., Derrick Johnson's). I'm sure that comes out of the spreadsheet. I'm gonna quickly comb through and look for other boo-boos

Thanks Colin!

@anlawyer anlawyer merged commit 1fbb895 into master Nov 2, 2020
@anlawyer anlawyer deleted the feat/add-map-link branch November 2, 2020 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants