Poller is including plugins that are not installed

[netniV]

So I did a bad thing.... I wrote a 'BADPLUGIN' plugin... And within even installing the plugin, it breaks poller!!

This plugin has the following three files

Info File

[info]
name = badplugin
version = 1.0
longname = A BAD PLUGIN
author = The Devil
email =
homepage = http://goto.hell
compat = 1.1.10
capabilities = online_view:1, online_mgmt:1, offline_view:0, offline_mgmt:0, remote_collect:0

File: setup.php

<?php
        throw new exception();

File: functions.php

<?php
        throw new exception();

Error Log

It results in this error log even though I never actually installed it:

2018/02/22 11:10:03 - CMDPHP ERRORS DETECTED - DISABLING PLUGIN 'badplugin'
--
2018/02/22 11:10:03 - CMDPHP PHP ERROR Backtrace: (CactiShutdownHandler)(/lib/functions.php: 4625 cacti_debug_backtrace)
thrown in file: /usr/share/cacti/develop/plugins/badplugin/setup.php on line: 2
#3 {main}
#2 /usr/share/cacti/develop/poller.php(716): snmpagent_poller_bottom()
#1 /usr/share/cacti/develop/lib/snmpagent.php(457): snmpagent_get_pluginslist()
#0 /usr/share/cacti/develop/lib/snmpagent.php(542): include_once()
Stack trace:
2018/02/22 11:10:03 - ERROR PHP ERROR in Plugin 'badplugin': Uncaught Exception in /usr/share/cacti/develop/plugins/badplugin/setup.php:2
2018/02/22 11:10:03 - SYSTEM STATS: Time:1.3055 Method:cmd.php Processes:1 Threads:N/A Hosts:5 HostsPerProcess:5 DataSources:65 RRDsProcessed:36
2018/02/22 11:05:03 - CMDPHP ERRORS DETECTED - DISABLING PLUGIN 'badplugin'
2018/02/22 11:05:03 - CMDPHP PHP ERROR Backtrace: (CactiShutdownHandler)(/lib/functions.php: 4625 cacti_debug_backtrace)
thrown in file: /usr/share/cacti/develop/plugins/badplugin/setup.php on line: 2
#3 {main}
#2 /usr/share/cacti/develop/poller.php(716): snmpagent_poller_bottom()
#1 /usr/share/cacti/develop/lib/snmpagent.php(457): snmpagent_get_pluginslist()
#0 /usr/share/cacti/develop/lib/snmpagent.php(542): include_once()
Stack trace:
2018/02/22 11:05:03 - ERROR PHP ERROR in Plugin 'badplugin': Uncaught Exception in /usr/share/cacti/develop/plugins/badplugin/setup.php:2

[cigamit]

Yea, that's bad. Seems I only fixed that bugger only half way.

[cigamit]

Well, on the face of it, that function was doing way too much. Going to make one more change...

[cigamit]

Should be resolved now. This was made simpler by the fact that we do not support pre 1.x plugins.

[netniV]

That works for me lol. I'll give it another stomach ache and see if your relief works ;-)