Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

i18n logging does not check write permission exists #3011

Closed
eschoeller opened this issue Oct 7, 2019 · 3 comments
Closed

i18n logging does not check write permission exists #3011

eschoeller opened this issue Oct 7, 2019 · 3 comments
Assignees
@netniV
Labels
bug Undesired behaviour resolved A fixed issue
Milestone
v1.2.8

Comments

@eschoeller
Copy link

Performing upgrade, I get these errors:

Warning: file_put_contents(/share/i18n.log): failed to open stream: Permission denied in /cacti/cacti-1.2.7a-prod/include/global_languages.php on line 756

Warning: file_put_contents(/share/i18n.log): failed to open stream: Permission denied in /cacti/cacti-1.2.7a-prod/include/global_languages.php on line 756

Warning: file_put_contents(/share/i18n.log): failed to open stream: Permission denied in /cacti/cacti-1.2.7a-prod/include/global_languages.php on line 756

Warning: Cannot modify header information - headers already sent by (output started at /cacti/cacti-1.2.7a-prod/include/global_languages.php:756) in /cacti/cacti-1.2.7a-prod/include/auth.php on line 109

The global_languages.php is looking for the existence of /share but not checking to make sure it's writable. I don't know why I have /share, but its being managed on my system by automount, so I can't remove it or change its permissions.
I hacked around this for now so it would write the log file to /tmp/ as that is the alternative location in the code.
@netniV
Copy link
Member

netniV commented Oct 7, 2019

My bad. that's actually debugging info and is only there whilst we were testing the new i18n situation out. It's only supposed to kick in if /share/ exists and that folder wasn't present on any of my systems... out of interest what is your OS and version?

@netniV netniV changed the title /share directory is not writable i18n logging does not check write permission exists causing runtime warnings Oct 7, 2019
@eschoeller
Copy link
Author

Red Hat Enterprise Linux Workstation release 6.10 (Santiago)

@netniV netniV self-assigned this Oct 8, 2019
@netniV netniV added the bug Undesired behaviour label Oct 8, 2019
@netniV netniV added this to the v1.2.8 milestone Oct 8, 2019
cigamit added a commit that referenced this issue Nov 9, 2019
@cigamit
Resolving Issue #3011
d2927a4 
i18n logging does not check write permission exists causing runtime warnings
@cigamit cigamit added the resolved A fixed issue label Nov 9, 2019
@cigamit
Copy link
Member

cigamit commented Nov 9, 2019

Resolved.

@cigamit cigamit closed this as completed Nov 9, 2019
@netniV netniV changed the title i18n logging does not check write permission exists causing runtime warnings i18n logging does not check write permission exists Dec 7, 2019
@github-actions github-actions bot locked and limited conversation to collaborators Jun 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@netniV netniV

Labels
bug Undesired behaviour resolved A fixed issue
Projects
None yet
Milestone
v1.2.8
Development

No branches or pull requests
3 participants
@cigamit @netniV @eschoeller