Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When using ping.php, UDP response times are not interpreted properly #3957

Merged
merged 2 commits into from
Nov 26, 2020

Conversation

hypnotoad
Copy link
Contributor

Fix the timing measurement for UDP. Otherwise, the timing is measured before the response of the client is received.

Fix the timing measurement for UDP. Otherwise, the timing is measured _before_ the response of the client is received.
@hypnotoad hypnotoad mentioned this pull request Nov 26, 2020
@TheWitness TheWitness changed the title Update ping.php Cacti ping.php does not collect correct respone time when using UDP ping Timing Nov 26, 2020
This is more how we would like the CHANGELOG's worded.  Appreciate you chipping in.
@TheWitness TheWitness merged commit 1194cf0 into Cacti:1.2.x Nov 26, 2020
@netniV netniV changed the title Cacti ping.php does not collect correct respone time when using UDP ping Timing When using ping.php, UDP response times are not interpreted properly Nov 30, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Mar 1, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants