-
-
Notifications
You must be signed in to change notification settings - Fork 404
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Less than sign inside items and labels of graph make them broken #465
Labels
bug
Undesired behaviour
Comments
Well, we have been trying to simplify the lib/rrd.php code. We escapted the title, but not the axis or the legends. So, I'm not surprised. Thanks for reporting. Should not take to long to find the proper approach to resolving this. |
cigamit
added a commit
that referenced
this issue
Mar 23, 2017
Less than sign inside items and labels of graph break graph
Please test with the latest lib/rrd.php and provide feedback. Thanks for reporting. |
cigamit
added a commit
that referenced
this issue
Mar 23, 2017
cigamit
added a commit
that referenced
this issue
Mar 23, 2017
cigamit
added a commit
that referenced
this issue
Mar 23, 2017
I noted that the various functional blocks are escaping differently, which is a clear sign you need to modularize that section of the code. Project for another day though.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Hi sorry for that very small bug :)
If set less than sign (<) for label and item it will make them broken.
Greater than sign works fine(>).
In label and item it behaves in little bit different way if replace with escape sequences please see below.
In graph debug it's converted to this:
--vertical-label="test(down if <1)" \ GPRINT:a:MIN:"MIN(<1)\:%8.2lf %s" \
So pay attention to double quotes inside command.
In graph debug it's converted to this:
--vertical-label='Sitecore State (down if <1)' \ GPRINT:a:MIN:'DOWN(<1)\:%8.2lf %s' \
Pay attention that in new version it's single quoted.
In graph debug it's converted to this:
--vertical-label='Sitecore State (down if <1)' \ GPRINT:a:MIN:'DOWN(lt;1)\:%8.2lf %s' \
You can see that escaped works fine for label, but inside item ampersand sign is missed that's why workaround doesn't work here.
Thank you
The text was updated successfully, but these errors were encountered: