Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issues with permission model and warnings #5142

Closed
TheWitness opened this issue Jan 6, 2023 · 2 comments
Closed

Fix issues with permission model and warnings #5142

TheWitness opened this issue Jan 6, 2023 · 2 comments
Labels
bug Undesired behaviour confirmed Bug is confirm by dev team resolved A fixed issue
Milestone

Comments

@TheWitness
Copy link
Member

TheWitness commented Jan 6, 2023

When you change permissions models from the previous of:

  • Permissive
  • Restrictive

To anything else, including:

  • Device Based
  • Graph Template Based

Cacti should warn the users that with a permission system change, there can be unexpected consequences, and that before making this change, they should understand that access to Graphs will change.

It should be noted, that the Graph Permission will continue to override any Template Restriction. So, for the documentation we should be clear that if you want the Graph Template and Device Permission Models to be the final solution, Graph permissions should be Deny by default.

Lastly, when the Permission Model is Device we should not show the Graph Templates permission tab in Users and User Groups, In addition, if the Permission Model is set to Graph Template, we should not be showing the Device permissions tab.

@TheWitness TheWitness added bug Undesired behaviour confirmed Bug is confirm by dev team labels Jan 6, 2023
@TheWitness TheWitness added this to the v1.2.24 milestone Jan 6, 2023
@netniV
Copy link
Member

netniV commented Jan 6, 2023

Lastly twice ?

@TheWitness
Copy link
Member Author

Thank God for the Edit button :)

@TheWitness TheWitness changed the title 1.2.23 - Warn when changing Permission Model in Cacti 1.2.23 - Correct issues with permission model including display of authorization UI elements and warnings Jan 7, 2023
TheWitness added a commit that referenced this issue Jan 7, 2023
* #5140: Cacti PHP 8.2 SNMP Errors with php-snmp Installed
* #5142: Correct issues with permission model including display of authorization UI elements and warnings
* #5143: When a Device has zero Graphs or Data Sources, it does not display the correct value
@netniV netniV changed the title 1.2.23 - Correct issues with permission model including display of authorization UI elements and warnings Fix issues with permission model and warnings Feb 15, 2023
@netniV netniV added the resolved A fixed issue label Feb 15, 2023
@github-actions github-actions bot locked and limited conversation to collaborators May 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Undesired behaviour confirmed Bug is confirm by dev team resolved A fixed issue
Projects
None yet
Development

No branches or pull requests

2 participants