Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Change Graph Template" action not availbale on graphs screen #610

Closed
dethmetaljeff opened this issue Apr 24, 2017 · 2 comments
Closed

"Change Graph Template" action not availbale on graphs screen #610

dethmetaljeff opened this issue Apr 24, 2017 · 2 comments

Comments

@dethmetaljeff
Copy link

In the graphs.php screen, the "Change Graph Template" action isn't showing up. Looks like the logic is to check that a template_id is being specified as a filter but the way it's implemented doesn't work for non-numeric tamplate_id's...in graphs.php:

if (get_nfilter_request_var('template_id') > 0) {
        $graph_actions += array(
                2  => __('Change Graph Template'),
        );
}

but my template_id's are non-numeric:

<option value='cg_132'>Linux - UDP Input Errors</option>
<option value='cg_335'>PING - Advanced Ping</option>
<option value='dq_56'>Sentry CDU - Current</option>
<option value='cg_110'>Sentry CDU - Current - 30Amp</option>
<option value='dq_91'>Sentry CDU - Humidity</option>

so this is never true. Perhaps we want != 0 instead?

@cigamit
Copy link
Member

cigamit commented Apr 25, 2017

Good point. Not sure how that happened.

cigamit added a commit that referenced this issue Apr 25, 2017
Change Graph Template action not available
@cigamit
Copy link
Member

cigamit commented Apr 25, 2017

Resolved, thanks!

@cigamit cigamit closed this as completed Apr 25, 2017
@github-actions github-actions bot locked and limited conversation to collaborators Jun 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants