Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When previewing a Template, button should show 'Close' not 'Import' #983

Closed
eschoeller opened this issue Sep 18, 2017 · 3 comments
Closed
Labels
enhancement General tag for an enhancement

Comments

@eschoeller
Copy link

When you select "preview" (or even if you don't) the results are displayed, followed by the import dialog again. Especially when you preview, it seems as if you could just hit the "Import" button to "accept the changes" but this doesn't work and just shoots you back to the Import Template dialog again. I am pretty sure in 0.8.6 days the import results were just displayed here, and perhaps an OK button, which would then take you back to the dialog.
**
image
**

@eschoeller
Copy link
Author

Also, the "Select a File" button remains with the same text, even after you have selected a file. This is also a bit misleading ... making you think perhaps it didn't actually select it. I think in the past this actually showed the file you were importing once it had been selected.

@cigamit
Copy link
Member

cigamit commented Sep 18, 2017

Okay, we should so some of this in a callback. Won't make it to 1.1.24. I'll mark this as an enhancement. Really appreciate the constructive criticism.

@cigamit cigamit added the enhancement General tag for an enhancement label Sep 18, 2017
@cigamit cigamit added the gui UI related issue label Feb 6, 2018
@cigamit cigamit removed the gui UI related issue label Mar 4, 2018
@netniV
Copy link
Member

netniV commented May 12, 2018

I have just tested this in 1.2 and a filename appears to the right of the "Select a File" button so I'm going to close it.

@netniV netniV closed this as completed May 12, 2018
netniV added a commit to netniV/cacti that referenced this issue May 12, 2018
@netniV netniV changed the title Import Template Preview is misleading When previewing a Template, button should show 'Close' not 'Import' Dec 27, 2018
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement General tag for an enhancement
Projects
None yet
Development

No branches or pull requests

3 participants