Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-work dataset invite links #98

Open
dignissimus opened this issue Oct 12, 2022 · 1 comment
Open

Re-work dataset invite links #98

dignissimus opened this issue Oct 12, 2022 · 1 comment

Comments

@dignissimus
Copy link
Member

From what I remember, dataset invite links are long and take up too much space. They should be shortened.

@dignissimus
Copy link
Member Author

If I recall correctly, I am using bcrypt. This is overkill. It makes sense to switch to invite IDs and store invite links in a database which allows invite links to be revokable.

One decision is whether user access is tied to an invite link or if an invite link only grants access to a user.

For me, the latter makes most sense and might be the best maintainability wise thinking about both code design and implementation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant