Feature/refactor #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karlvr
requested changes
Oct 10, 2018
added 2 commits
October 11, 2018 07:22
karlvr
reviewed
Oct 10, 2018
Example/Tests/Tests.swift
Outdated
| @@ -82,8 +85,17 @@ class Tests: XCTestCase, SucculentTest { | |||
| } | |||
| } | |||
|
|
|||
| func testIgnoredParametersForTrace() { | |||
| // This tests a recording that was made without the ignoredParams that we’re going to run the replay with. So the recording contains query strings with the ignored param. We ensure that we can still match those requests. | |||
There was a problem hiding this comment.
This should be a /// comment above the function declaration.
karlvr
reviewed
Oct 10, 2018
karlvr
reviewed
Oct 10, 2018
karlvr
reviewed
Oct 10, 2018
karlvr
reviewed
Oct 10, 2018
|
|
||
| public convenience init(traceUrl: URL, baseUrl: URL? = nil, ignoreVersioningRequests: [String] = []) { | ||
| self.init() | ||
| public convenience init(replayFrom traceUrl: URL?, passThroughBaseUrl baseUrl: URL? = nil, configuration: Configuration? = nil) { |
There was a problem hiding this comment.
Documentation:
Initialise Succulent in replay mode, with an optional trace file to replay from, a pass-through URL to use if a match if not found in the trace file, and configuration.
karlvr
reviewed
Oct 10, 2018
| } | ||
|
|
||
| public convenience init(recordUrl: URL, baseUrl: URL) { | ||
| self.init() | ||
| public convenience init(recordTo recordUrl: URL, baseUrl: URL, configuration: Configuration? = nil) { |
There was a problem hiding this comment.
Documentation:
Initialise Succulent in recording mode, with a URL to record the trace to and the base URL for the upstream server that we're recording.
karlvr
approved these changes
Oct 10, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.