httploader: Close resp body on bad status code

Related to #5158
caddyserver · Oct 24, 2022 · 817470d · mohammed90 · Oct 24, 2022 · mholt
1 parent bbe3663
commit 817470d
Showing 1 changed file with 1 addition and 0 deletions.
diff --git a/caddyconfig/httploader.go b/caddyconfig/httploader.go
@@ -124,6 +124,7 @@ func attemptHttpCall(client *http.Client, request *http.Request) (*http.Response
 	if err != nil {
 		return nil, fmt.Errorf("problem calling http loader url: %v", err)
 	} else if resp.StatusCode < 200 || resp.StatusCode > 499 {
+		resp.Body.Close()
 defer resp.Body.Close() 
 defer resp.Body.Close() 
 		return nil, fmt.Errorf("bad response status code from http loader url: %v", resp.StatusCode)
 	}
 	return resp, nil