Skip to content

Commit

Permalink
reverseproxy: api: Remove misleading 'healthy' value
Browse files Browse the repository at this point in the history
In v2.5.0, upstream health was fixed such that whether an upstream is
considered healthy or not is mostly up to each individual handler's
config. Since "healthy" is an opinion, it is not a global value.

I unintentionally left in the "healthy" field in the API endpoint for
checking upstreams, and it is now misleading (see #4792).

However, num_requests and fails remains, so health can be determined by
the API client, rather than having it be opaquely (and unhelpfully)
determined for the client.

If we do restore this value later on, it'd need to be replicated once
per reverse_proxy handler according to their individual configs.
  • Loading branch information
mholt committed Jun 2, 2022
1 parent 3d18bc5 commit 9864b13
Showing 1 changed file with 0 additions and 1 deletion.
1 change: 0 additions & 1 deletion modules/caddyhttp/reverseproxy/admin.go
Expand Up @@ -35,7 +35,6 @@ type adminUpstreams struct{}
// upstreamResults holds the status of a particular upstream
type upstreamStatus struct {
Address string `json:"address"`
Healthy bool `json:"healthy"`
NumRequests int `json:"num_requests"`
Fails int `json:"fails"`
}
Expand Down

0 comments on commit 9864b13

Please sign in to comment.