Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider shipping release tarball with vendored dependencies #4573

Closed
illiliti opened this issue Feb 13, 2022 · 2 comments · Fixed by #5403
Closed

Consider shipping release tarball with vendored dependencies #4573

illiliti opened this issue Feb 13, 2022 · 2 comments · Fixed by #5403
Assignees
Labels
CI/CD 🔩 Automated tests, releases help wanted 🆘 Extra attention is needed

Comments

@illiliti
Copy link

For example, dnscrypt-proxy does this by simply maintaining vendor directory. You can also setup CI to vendor dependencies into release tarball without needing to keep vendor directory within repository. Here is the command that can be used for this: go mod vendor

With vendored dependencies, i can build caddy from source without internet connection by using this command: go build -mod=vendor

@mholt
Copy link
Member

mholt commented Feb 14, 2022

I suppose we could do this, as long as it's only for a release asset.

@francislavoie
Copy link
Member

This is done in #5403 😀

Sorry it took us so long, it was sorta tricky since we needed help from goreleaser upstream, then it just kinda fell off our TODO list.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/CD 🔩 Automated tests, releases help wanted 🆘 Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants