Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The state of the go packages #976

Open
4 of 15 tasks
illiliti opened this issue Feb 13, 2022 · 6 comments
Open
4 of 15 tasks

The state of the go packages #976

illiliti opened this issue Feb 13, 2022 · 6 comments

Comments

@illiliti
Copy link
Member

illiliti commented Feb 13, 2022

Some(well, all of them except dnscrypt-proxy) go packages still use internet connection to fetch dependencies. This is bad because only kiss itself should be allowed(we should really enforce this via unshare) to fetch something from internet. We should use go build -mod=vendor where possible, and if not possible - convince upstream to add support for it.

@Vouivre
Copy link

Vouivre commented Feb 22, 2022

I'm not the maintainer of go-ipfs

$ kiss-maintainer go-ipfs                                                      
=> /home/user/repos/community/community/go-ipfs
Daniel M. Matongo <me@danielm.pw>

@mmatongo: can you have a look at it ?

@mmatongo
Copy link

I keep forgetting to do this for some reason, I'll send two PR's in a bit.

@illiliti
Copy link
Member Author

I'm not the maintainer of go-ipfs

Fixed, thanks.

@dilyn-corner
Copy link
Member

@aabacchus -- maybe poke amfora?

@git-bruh -- maybe poke github-cli?

The others are either wontfix or ignored -- I suppose we should just consider it a lost cause.

Maintainers are probably welcome to vendor dependencies themselves and point sources to their fork (though should probably be discussed...)

@aabacchus
Copy link
Member

Does anyone more familiar with GitHub actions want to have a go at this? makew0rld/amfora#296 (comment)

@aabacchus
Copy link
Member

by the way, the maintainer of aerc said they don't want the "burden" of vendoring deps in tarballs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants