Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

golangci-lint should run on multiple platforms #4875

Closed
karmanyaahm opened this issue Jul 9, 2022 · 1 comment
Closed

golangci-lint should run on multiple platforms #4875

karmanyaahm opened this issue Jul 9, 2022 · 1 comment
Labels
CI/CD 🔩 Automated tests, releases help wanted 🆘 Extra attention is needed

Comments

@karmanyaahm
Copy link
Contributor

Something I found when working on my PR was that platform specific code using // go:build is not checked in ci by .github/workflows/lint.yml.

An example where Linux works, but macOS doesn't (due to listen.go and listen_linux.go in that branch being different): https://github.com/karmanyaahm/caddy/actions/runs/2639453990
See this for a possible fix: karmanyaahm@68bd9d5
@francislavoie
Copy link
Member

Feel free to open a PR. Thanks for letting us know!

@francislavoie francislavoie added the CI/CD 🔩 Automated tests, releases label Jul 12, 2022
@mholt mholt added the help wanted 🆘 Extra attention is needed label Jul 26, 2022
u5surf added a commit to u5surf/caddy that referenced this issue Jul 26, 2022
@u5surf
ci: Run golangci-lint on multiple os(caddyserver#4875)
69f48db
u5surf added a commit to u5surf/caddy that referenced this issue Jul 26, 2022
@u5surf
ci: Run golangci-lint on multiple os(caddyserver#4875)
3a1830e
@u5surf u5surf mentioned this issue Jul 26, 2022
Merged
u5surf added a commit to u5surf/caddy that referenced this issue Jul 26, 2022
@u5surf
ci: Run golangci-lint on multiple os(caddyserver#4875)
dff4356
u5surf added a commit to u5surf/caddy that referenced this issue Jul 27, 2022
@u5surf
ci: Run golangci-lint on multiple os(caddyserver#4875)
4a68153
u5surf added a commit to u5surf/caddy that referenced this issue Jul 27, 2022
@u5surf
ci: Run golangci-lint on multiple os(caddyserver#4875)
4d6d2da
francislavoie pushed a commit that referenced this issue Jul 27, 2022
@u5surf
ci: Run golangci-lint on multiple os(#4875) (#4913)
c833e3b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
CI/CD 🔩 Automated tests, releases help wanted 🆘 Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@mholt @francislavoie @karmanyaahm