Caddy 2.6.x - handle_path behavior change in relation to php_fastcgi #5073
Comments
|
I was able to somewhat fix the issue by changing the config to If you feel this is not an issue, please feel free to close it i thought I'd share the issues i had upgrading. |
|
Thanks for letting us know!
That was redundant, since What exactly breaks though?
Why does that fix something? I guess I don't really understand. Some of the log entries don't make much sense as they don't look like full log lines, e.g. missing some response information (bad nesting maybe?) ... |
Hi thanks for the quick reply, i copied the logs as they are from caddy using both i am not quite sure why Edit: It seems does work for logsfor both |
|
is If so, I think that's normal/expected to redirect to Edit: oh, it redirects |
|
redirecting |
|
@arabcoders You're sure this worked in v2.5.2 with the exact same config? And can you please test the patch in #5076? |
Hi replying from my phone, it's almost 12 AM where i am right now. I think i still have 2.5 version somewhere i will test both the PR version and the old version. and i'm quite sure the config i gave is exact one running in my old 2.5 setup. But to be sure i will retest them tomorrow morning. Thanks for the quick PR |
|
Thank you, that would be great! Have a good sleep |
Thank you, i have tested the following versions 2.5, 2.6, caddy_Linux_go1.19_e8cd495 which is linked in PR artifact, here are the following findings Directory StructureCaddyfiletested commands$ http http://localhost:8084/app
$ http http://localhost:8084/app/
$ http http://localhost:8084/app/index.phpv2.5 logsv2.5.2 h1:eCJdLyEyAGzuQTa5Mh3gETnYWDClo1LjtQm2q9RNZrs= v2.6 logsv2.6.1 h1:EDqo59TyYWhXQnfde93Mmv4FJfYe00dO60zMiEt+pzo= PR versione8cd495 (23 Sep 22 22:48 UTC) Summaryresults WITH
|
| Version | Path | Status | Response |
|---|---|---|---|
| v2.5 | /app | 308 | Location: / |
| v2.6 | /app | 308 | Location: ./ |
| vPR | /app | 308 | Location: /app/ |
| v2.5 | /app/ | 200 | shows php output |
| v2.6 | /app/ | 308 | Location: / |
| vPR | /app/ | 308 | Location: /app// |
| v2.5 | /app/index.php | 200 | shows php output |
| v2.6 | /app/index.php | 200 | shows php output |
| vPR | /app/index.php | 200 | shows php output |
results WITHOUT uri strip_prefix /app
| Version | Path | Status | Response |
|---|---|---|---|
| v2.5 | /app | 308 | Location: / |
| v2.6 | /app | 308 | Location: ./ |
| vPR | /app | 308 | Location: /app/ |
| v2.5 | /app/ | 200 | shows php output |
| v2.6 | /app/ | 200 | shows php output |
| vPR | /app/ | 200 | shows php output |
| v2.5 | /app/index.php | 200 | shows php output |
| v2.6 | /app/index.php | 200 | shows php output |
| vPR | /app/index.php | 200 | shows php output |
it seems uri strip_prefix /app somehow altering the path even though it should have 0 effect as you indicated it being redundant.
|
Wow, that's an excellent report 🤩 thanks for all the detail, that's awesome! |
|
Oh wow, thank you for the well-organized report. I'll investigate more! But I think we're making progress and it looks like things are mostly working as expected, right? Just a few little quirks to iron out. (Like sending 308 to |
|
No problem, glad to be able to help.
I think so too, it seems strip_prefix is doing something that it should not do, in my opinion, strip_prefix should return uri as it is if the path does not match. i think probably its quirk in the Caddyfile parser and the reordering maybe? but then again route directive should override automatic re-ordering. Honestly i have little golang experience to dig deeper in caddy internals. |
|
@mholt i found two other odd problems, one seems to be breaking change although small, and another problem regarding caddy reload not picking up changes unless restart is done the breaking change is in the other problem in config reload is it seems it relates to http/3 keep alive connection? not exactly sure i'll have to dig more tomorrow |
No, it was always We made a change to use a separate library for the command flag parsing which disallows
I don't understand. Please elaborate in detail. What behaviour are you seeing? What's the problem exactly? (No rush, just want to mention that this isn't actionable as-is) |
i agree i remember being confused why
Sure, I'll hopefully have more information tomorrow as i dig more into it but right now, this is the behavior i am noticing. have a caddy server running, edit the config do caddy reload, i expect the changes to |
Which was part of the problem we were trying to solve. We couldn't control this, because the Go stdlib produced the help doc itself, and always used
What's in your logs when you reload? What do you see when you query the admin endpoint to get your current config (or what's in your |
sorry about the delay in response here are so logs here is the systemd service file and the command used to reload. was working fine on 2.5 [Unit]
Description=Caddy
Documentation=https://caddyserver.com/docs/
After=network.target network-online.target
Requires=network-online.target
[Service]
Type=notify
User=caddy
Group=caddy
Environment=TZ=Asia/Kuwait
Environment=XDG_DATA_HOME=/backup/src/apps/caddy/data
Environment=XDG_CONFIG_HOME=/backup/src/apps/caddy/config
ExecStartPre=/usr/local/bin/caddy validate --config /backup/src/apps/caddy/config/Caddyfile --adapter caddyfile
ExecStart=/usr/local/bin/caddy run --environ --config /backup/src/apps/caddy/config/Caddyfile --adapter caddyfile
ExecReload=/usr/local/bin/caddy reload --config /backup/src/apps/caddy/config/Caddyfile --adapter caddyfile
TimeoutStopSec=5s
#LimitNOFILE=1048576
#LimitNPROC=512
#PrivateTmp=true
#ProtectSystem=full
AmbientCapabilities=CAP_NET_BIND_SERVICE
[Install]
WantedBy=multi-user.target
|
|
@arabcoders Thanks for the additional info. I was able to write a simple test case to reproduce the |
Sure, i will test it later today and report back |
Sorry about the delay, test results for seems to be working as expected now. |
fastcgi: Redirect using original URI path (fix #5073) and rewrite: Only trim prefix if matched
|
Hurray! Thanks for confirming. I'll close the issue and merge that in. |
Hello,
i was testing caddy 2.6 to deploy on my home network, and i noticed that using the same config for 2.5 and 2.6 no longer works correctly for
handleandhandle_pathFor example this Caddyfile works for 2.5 and produce correct response.
However using the same config for 2.6 produce 308 for
/app/app/, we have to use/app/index.phpto get the app to work, otherwise308response is returnedLogs
v2.6.1 h1:EDqo59TyYWhXQnfde93Mmv4FJfYe00dO60zMiEt+pzo=
[ { "request": { "remote_ip": "127.0.0.1", "remote_port": "55046", "proto": "HTTP/1.1", "method": "GET", "host": "localhost:8084", "uri": "/app", "headers": { "User-Agent": [ "HTTPie/2.6.0" ], "Accept-Encoding": [ "gzip, deflate" ], "Accept": [ "*/*" ], "Connection": [ "keep-alive" ] } }, "method": "GET", "uri": "/" }, { "request": { "remote_ip": "127.0.0.1", "remote_port": "55046", "proto": "HTTP/1.1", "method": "GET", "host": "localhost:8084", "uri": "/", "headers": { "User-Agent": [ "HTTPie/2.6.0" ], "Accept-Encoding": [ "gzip, deflate" ], "Accept": [ "*/*" ], "Connection": [ "keep-alive" ] } }, "method": "GET", "uri": "." }, { "request": { "remote_ip": "127.0.0.1", "remote_port": "55046", "proto": "HTTP/1.1", "method": "GET", "host": "localhost:8084", "uri": "/app", "headers": { "Accept": [ "*/*" ], "Connection": [ "keep-alive" ], "User-Agent": [ "HTTPie/2.6.0" ], "Accept-Encoding": [ "gzip, deflate" ] } }, "user_id": "", "duration": 0.00009701, "size": 0, "status": 308, "resp_headers": { "Server": [ "Caddy" ], "Location": [ "./" ], "Content-Type": [] } }, { "request": { "remote_ip": "127.0.0.1", "remote_port": "55052", "proto": "HTTP/1.1", "method": "GET", "host": "localhost:8084", "uri": "/app/", "headers": { "User-Agent": [ "HTTPie/2.6.0" ], "Accept-Encoding": [ "gzip, deflate" ], "Accept": [ "*/*" ], "Connection": [ "keep-alive" ] } }, "method": "GET", "uri": "/" }, { "request": { "remote_ip": "127.0.0.1", "remote_port": "55052", "proto": "HTTP/1.1", "method": "GET", "host": "localhost:8084", "uri": "/app/", "headers": { "User-Agent": [ "HTTPie/2.6.0" ], "Accept-Encoding": [ "gzip, deflate" ], "Accept": [ "*/*" ], "Connection": [ "keep-alive" ] } }, "user_id": "", "duration": 0.000093239, "size": 0, "status": 308, "resp_headers": { "Location": [ "/" ], "Content-Type": [], "Server": [ "Caddy" ] } }, { "request": { "remote_ip": "127.0.0.1", "remote_port": "55058", "proto": "HTTP/1.1", "method": "GET", "host": "localhost:8084", "uri": "/app/index.php", "headers": { "User-Agent": [ "HTTPie/2.6.0" ], "Accept-Encoding": [ "gzip, deflate" ], "Accept": [ "*/*" ], "Connection": [ "keep-alive" ] } }, "method": "GET", "uri": "/index.php" }, { "dial": "/var/run/php/php8.1-fpm.sock", "total_upstreams": 1 }, { "request": { "remote_ip": "127.0.0.1", "remote_port": "55058", "proto": "HTTP/1.1", "method": "GET", "host": "localhost:8084", "uri": "/index.php", "headers": { "Accept": [ "*/*" ], "X-Forwarded-For": [ "127.0.0.1" ], "User-Agent": [ "HTTPie/2.6.0" ], "Accept-Encoding": [ "gzip, deflate" ], "X-Forwarded-Proto": [ "http" ], "X-Forwarded-Host": [ "localhost:8084" ] } }, "env": { "REQUEST_URI": "/app/index.php", "HTTP_ACCEPT": "*/*", "GATEWAY_INTERFACE": "CGI/1.1", "REMOTE_HOST": "127.0.0.1", "REMOTE_USER": "", "REQUEST_SCHEME": "http", "HTTP_HOST": "localhost:8084", "SERVER_PORT": "8084", "PATH_INFO": "", "REMOTE_PORT": "55058", "SERVER_NAME": "localhost", "HTTP_X_FORWARDED_FOR": "127.0.0.1", "REMOTE_ADDR": "127.0.0.1", "REMOTE_IDENT": "", "HTTP_ACCEPT_ENCODING": "gzip, deflate", "HTTP_X_FORWARDED_HOST": "localhost:8084", "AUTH_TYPE": "", "SCRIPT_FILENAME": "/home/user/tests/test_caddy/test/index.php", "HTTP_USER_AGENT": "HTTPie/2.6.0", "DOCUMENT_ROOT": "/home/user/tests/test_caddy/test", "REQUEST_METHOD": "GET", "SERVER_PROTOCOL": "HTTP/1.1", "CONTENT_LENGTH": "", "DOCUMENT_URI": "/index.php", "QUERY_STRING": "", "SERVER_SOFTWARE": "Caddy/v2.6.1", "SCRIPT_NAME": "/index.php", "HTTP_X_FORWARDED_PROTO": "http", "CONTENT_TYPE": "" }, "dial": "/var/run/php/php8.1-fpm.sock", "env": { "GATEWAY_INTERFACE": "CGI/1.1", "REQUEST_URI": "/app/index.php", "HTTP_ACCEPT": "*/*", "PATH_INFO": "", "REMOTE_HOST": "127.0.0.1", "REMOTE_USER": "", "REQUEST_SCHEME": "http", "HTTP_HOST": "localhost:8084", "SERVER_PORT": "8084", "REMOTE_ADDR": "127.0.0.1", "REMOTE_PORT": "55058", "SERVER_NAME": "localhost", "HTTP_X_FORWARDED_FOR": "127.0.0.1", "AUTH_TYPE": "", "REMOTE_IDENT": "", "HTTP_ACCEPT_ENCODING": "gzip, deflate", "HTTP_X_FORWARDED_HOST": "localhost:8084", "DOCUMENT_ROOT": "/home/user/tests/test_caddy/test", "SCRIPT_FILENAME": "/home/user/tests/test_caddy/test/index.php", "HTTP_USER_AGENT": "HTTPie/2.6.0", "CONTENT_LENGTH": "", "REQUEST_METHOD": "GET", "SERVER_PROTOCOL": "HTTP/1.1", "QUERY_STRING": "", "DOCUMENT_URI": "/index.php", "CONTENT_TYPE": "", "SERVER_SOFTWARE": "Caddy/v2.6.1", "SCRIPT_NAME": "/index.php", "HTTP_X_FORWARDED_PROTO": "http" }, "request": { "remote_ip": "127.0.0.1", "remote_port": "55058", "proto": "HTTP/1.1", "method": "GET", "host": "localhost:8084", "uri": "/index.php", "headers": { "Accept": [ "*/*" ], "X-Forwarded-For": [ "127.0.0.1" ], "User-Agent": [ "HTTPie/2.6.0" ], "Accept-Encoding": [ "gzip, deflate" ], "X-Forwarded-Proto": [ "http" ], "X-Forwarded-Host": [ "localhost:8084" ] } } }, { "upstream": "unix//var/run/php/php8.1-fpm.sock", "duration": 0.009203193, "request": { "remote_ip": "127.0.0.1", "remote_port": "55058", "proto": "HTTP/1.1", "method": "GET", "host": "localhost:8084", "uri": "/index.php", "headers": { "User-Agent": [ "HTTPie/2.6.0" ], "Accept-Encoding": [ "gzip, deflate" ], "X-Forwarded-Proto": [ "http" ], "X-Forwarded-Host": [ "localhost:8084" ], "Accept": [ "*/*" ], "X-Forwarded-For": [ "127.0.0.1" ] } }, "headers": { "Content-Type": [ "text/html; charset=UTF-8" ] }, "status": 200 }, { "request": { "remote_ip": "127.0.0.1", "remote_port": "55058", "proto": "HTTP/1.1", "method": "GET", "host": "localhost:8084", "uri": "/app/index.php", "headers": { "Accept-Encoding": [ "gzip, deflate" ], "Accept": [ "*/*" ], "Connection": [ "keep-alive" ], "User-Agent": [ "HTTPie/2.6.0" ] } }, "user_id": "", "duration": 0.00955324, "size": 87843, "status": 200, "resp_headers": { "Server": [ "Caddy" ], "Content-Type": [ "text/html; charset=UTF-8" ] } } ]The text was updated successfully, but these errors were encountered: