templates: delete ETag and Last-Modified headers in ServeHTTP #2338
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mholt
approved these changes
Nov 18, 2018
mholt
reviewed
Nov 18, 2018
| @@ -110,6 +110,10 @@ func (t Templates) ServeHTTP(w http.ResponseWriter, r *http.Request) (int, error | |||
| // set the actual content length now that the template was executed | |||
| w.Header().Set("Content-Length", strconv.Itoa(buf.Len())) | |||
|
|
|||
| // delete the headers related to cache | |||
There was a problem hiding this comment.
Note for future work: I think a comment for the next two lines is good, but this comment just restates what is obvious from the code. Better would be to have a comment explaining WHY the next two lines are present.
There was a problem hiding this comment.
FWIW I think it's at least more useful than just stating the obvious, because it's specific domain knowledge that ETag and Last-Modified are cache-related. Not everyone would know that. But I agree that it could explain why those headers are being deleted.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1. What does this change do, exactly?
In tempates middleware, delete the two headers related to cache.
2. Please link to the relevant issues.
#1920
3. Which documentation changes (if any) need to be made because of this PR?
None.
4. Checklist