map: Prevent output destinations overlap with Caddyfile shorthands #4657
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Essentially, this tries to prevent configs like this:
Where the output
{path}
is no good, because it's one of the placeholder shorthands. This means that the map destination would actually clobber an existing replacer output, and produce unexpected behaviour.The implementation is kiiinda tricky though.
Since shorthand replacement happens before directive parsing (this surprised me when I was working on this, but "duh" I should've realized sooner), the
map
's Caddyfile parser actually sees{http.request.uri.path}
instead of{path}
; this means that we need to actually look for the replacements and map them back to the shorthand (for the error message).With this change, the above Caddyfile will now spit out:
Also, this adds
{vars.*}
shorthand. Nice to have now that we have avars
directive.