Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

logging: Use RedirectStdLog #4732

Merged
merged 2 commits into from Apr 28, 2022
Merged

logging: Use RedirectStdLog #4732

merged 2 commits into from Apr 28, 2022

Conversation

francislavoie
Copy link
Member

Fixes #4688

Before:

$ caddy trust --address localhost:2021 --ca local
2022/04/27 02:21:33.454 WARN    installing root certificate (you might be prompted for password)        {"path": "localhost:2021/pki/ca/local"}
2022/04/26 22:21:33 Note: NSS support is not available on your platform
2022/04/26 22:21:33 define JAVA_HOME environment variable to use the Java trust
2022/04/26 22:21:34 certificate installed properly in windows trusts

After:

$ caddy trust --address localhost:2021 --ca local
2022/04/27 02:39:49.365 WARN    installing root certificate (you might be prompted for password)        {"path": "localhost:2021/pki/ca/local"}
2022/04/27 02:39:49.367 INFO    Note: NSS support is not available on your platform
2022/04/27 02:39:49.367 INFO    define JAVA_HOME environment variable to use the Java trust
2022/04/27 02:39:50.939 INFO    certificate installed properly in windows trusts

@francislavoie francislavoie added the feature ⚙️ New feature or request label Apr 27, 2022
@francislavoie francislavoie added this to the v2.5.1 milestone Apr 27, 2022
Copy link
Member

@mholt mholt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, let's try it! Thanks Francis.

@mholt mholt merged commit 3017b24 into master Apr 28, 2022
@mholt mholt deleted the zap-redirectstdlog branch April 28, 2022 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature ⚙️ New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consider using zap's RedirectStdLog
2 participants