Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

httpcaddyfile: Fix duplicate access log when debug is on #4746

Merged
merged 1 commit into from Apr 28, 2022
Merged

httpcaddyfile: Fix duplicate access log when debug is on #4746

merged 1 commit into from Apr 28, 2022

Conversation

francislavoie
Copy link
Member

When access logging is turned on with the log directive, and the debug global option is used, the default logger would not correctly get the "exclude": ["http.log.access.log0"] attached to it; so you end up with the access log written twice, unintentionally.

The added adapt test fails before this change, i.e. exclude is missing from default.

@francislavoie francislavoie added the bug 🐞 Something isn't working label Apr 28, 2022
@francislavoie francislavoie added this to the v2.5.1 milestone Apr 28, 2022
mholt
mholt approved these changes Apr 28, 2022
View reviewed changes
Copy link
Member

@mholt mholt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh wow, thanks. Not sure how I didn't notice that before.

@francislavoie francislavoie merged commit af73215 into master Apr 28, 2022
@francislavoie francislavoie deleted the duplicate-access-log-with-debug branch April 28, 2022 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mholt mholt mholt approved these changes

Assignees
No one assigned
Labels
bug 🐞 Something isn't working
Projects
None yet
Milestone
v2.5.1
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@francislavoie @mholt