Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

templates: Documentation consistency #4796

Merged
merged 1 commit into from May 17, 2022
Merged

templates: Documentation consistency #4796

merged 1 commit into from May 17, 2022

Conversation

davidbgk
Copy link
Contributor

Otherwise, it might be confusing for beginners (like me!)

@davidbgk
Consistency in templates' documentation
e342f5b 
Otherwise, it might be confusing for beginners (like me!)
@CLAassistant
Copy link

CLAassistant commented May 17, 2022 •
edited

CLA assistant check
All committers have signed the CLA.

@francislavoie
Copy link
Member

I'm confused -- consistency in relation to what?

@davidbgk
Copy link
Contributor Author

I'm confused -- consistency in relation to what?

Sorry, I wasn't explicit myself 😅

Line 101 of the same file, just above:

// **filename.html**

francislavoie
francislavoie approved these changes May 17, 2022
View reviewed changes
Copy link
Member

@francislavoie francislavoie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, yeah that makes sense 👍 thanks!

@francislavoie francislavoie changed the title Consistency in templates' documentation templates: Documentation consistency May 17, 2022
@francislavoie francislavoie added the documentation 📚 Improvements or additions to documentation label May 17, 2022
@francislavoie francislavoie added this to the v2.5.2 milestone May 17, 2022
@francislavoie francislavoie merged commit 9e760e2 into caddyserver:master May 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@francislavoie francislavoie francislavoie approved these changes

Assignees
No one assigned
Labels
documentation 📚 Improvements or additions to documentation
Projects
None yet
Milestone
v2.5.2
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@davidbgk @CLAassistant @francislavoie