Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

admin api: expect quoted ETags #4879

Merged
merged 2 commits into from Jul 12, 2022
Merged

admin api: expect quoted ETags #4879

merged 2 commits into from Jul 12, 2022

Conversation

jhwz
Copy link
Collaborator

@jhwz jhwz commented Jul 11, 2022

Follow up from #4579 (comment)

Expects the If-Match HTTP header to be quoted, and will return the ETag HTTP header in quotes.

mholt
mholt approved these changes Jul 11, 2022
View reviewed changes
Copy link
Member

@mholt mholt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM. Just one question I noticed.

admin.go Outdated Show resolved Hide resolved
@mholt mholt added this to the v2.5.2 milestone Jul 11, 2022
@mholt
Copy link
Member

mholt commented Jul 12, 2022

I went ahead and did a minor refactoring to clean up the use of makeEtag() and I think I'll merge it in a moment and release v2.5.2. Thank you again!!

@mholt mholt merged commit ad3a83f into master Jul 12, 2022
@mholt mholt deleted the admin-api-quoted-etag branch July 12, 2022 18:23
@jhwz
Copy link
Collaborator Author

jhwz commented Jul 13, 2022

Cool! I got caught up sorry and didn't have time to make the change

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mholt mholt mholt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v2.5.2
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jhwz @mholt