-
-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adding h2c graceful shutdown #4920
base: master
Are you sure you want to change the base?
Conversation
Thanks! I'm looking forward to reviewing this. |
0f9849a
to
df54c0c
Compare
Thank you for this change @WeidiDeng -- if it's OK with you, I'm going to bump this to after 2.6 (or at least after its initial beta) just so I can stay on a self-imposed schedule 🤪 I will review this though! |
# Conflicts: # modules/caddyhttp/app.go
) | ||
|
||
// h2chandler is a Handler which counts possible h2c upgrade requests | ||
type h2chandler struct { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't this be uppercase, as a separate word?
type h2chandler struct { | |
type h2cHandler struct { |
Will take another look when it's updated and ready for another review (as discussed in Slack). 💯 |
Fixes 4907